[Bug 15319] New: Use Bootstrap modal for MARC preview when performing batch record modifications
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Bug ID: 15319 Summary: Use Bootstrap modal for MARC preview when performing batch record modifications Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/batch_record_modification.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 8290 When confirming batch record modifications, the "Preview MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45458&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45458|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45462&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. No regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45462|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45483&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. No regression. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45484&action=edit Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, Could you have a look at the second patch please? I have moved the marcPreview div to avoid duplication in biblios and authorities. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45484|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45491&action=edit [SIGNED-OFF] Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Good catch Jonathan, thank you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|minor |enhancement --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org