[Bug 35346] New: 'Accept essential cookies' should always appear if CookieConsent is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Bug ID: 35346 Summary: 'Accept essential cookies' should always appear if CookieConsent is enabled Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Right now, if you don't have any CookieConsentedJS cookies defined but do have CookieConsent set to 'require' then you are shown the footer bar with just an 'Accept all cookies' button. This is misleading, the button should be 'Accept essential cookies' as only essential cookies are going to be accepted.. there are no further cookies in 'all'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34793 |35347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347 [Bug 35347] 'More information' should always display in cookie consent bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159050&action=edit Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 [Bug 35348] Cookie information should be available regardless of whether you are logged in or not -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159050|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159137&action=edit Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- All good for me. Waiting for transitive dependency bug 34793. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159137|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162059&action=edit Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Bug 35346 depends on bug 35347, which changed state. Bug 35347 Summary: 'More information' should always display in cookie consent bar https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35347 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org