[Bug 21788] New: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Bug ID: 21788 Summary: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 19066 introduces the new column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |19066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 [Bug 19066] Add branchcode to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82094&action=edit Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82095&action=edit Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82094|0 |1 is obsolete| | Attachment #82095|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82285&action=edit Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82286&action=edit Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Bug 21788 depends on bug 19066, which changed state. Bug 19066 Summary: Add branchcode to accountlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82285|0 |1 is obsolete| | Attachment #82286|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83721&action=edit Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83722&action=edit Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on enhancement in bug 19066, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org