[Bug 8645] New: Fix background-job-progressbar.js for translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Priority: P5 - low Change sponsored?: --- Bug ID: 8645 Assignee: gmcharlt@gmail.com Summary: Fix background-job-progressbar.js for translations Severity: normal Classification: Unclassified OS: All Reporter: pelletiermaxime@gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha Respect coding guidelines for translations in javascript by replacing ' by ". Fixes the page for the fr-CA translation (that contains a '). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 11623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11623&action=edit Small patch to fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11623|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11627&action=edit [SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations Respect coding guidelines for translations in javascript by replacing ' by ". Fixes the page for the french translation (that contains a '). Sponsored by the CCSR. http://bugs.koha-community.org/show_bug.cgi?id=8645 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|gmcharlt@gmail.com |pelletiermaxime@gmail.com --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This patch clearly does no harm, so I will trust that it does good. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Maxime, This patch does not work for me. I think the .js files are not translatable. Could someone confirm that ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #5 from Maxime Pelletier <pelletiermaxime@gmail.com> --- (In reply to comment #4)
Hi Maxime,
This patch does not work for me. I think the .js files are not translatable. Could someone confirm that ?
Well, damn. Forgot to add a _() in the patch to allow to be translatable. Will upload a new patch in a few hours. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Is that what this patch is supposed to enable? JavaScript files are not translatable. Translatable strings should be moved to the template: http://wiki.koha-community.org/wiki/Coding_Guidelines#Enabling_translation_o... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 --- Comment #7 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Arg. Yeah... the code was in an .inc file in 3.6 and I just merged my code in the .js without thinking about it. I will try to fix it to make it translatable in a template. Thanks. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org