[Bug 29867] New: Reindent authorized values administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Bug ID: 29867 Summary: Reindent authorized values administration template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org I would like to update the authorized values administration template so that it has consistent indentation. It needs to have some tabs replaced with spaces and to have trailing spaces removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129361&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129362&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 [Bug 7374] Add remote image option for authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129361|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129631&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129362|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129632&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129631|0 |1 is obsolete| | Attachment #129632|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130062&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130063&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm really sorry patch does not apply anymore on master. Looks like it is because of Bug 29859. I'll push fastly after rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130062|0 |1 is obsolete| | Attachment #130063|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130444&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130445&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks a lot Owen. This template looks a looooot more clear now ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org