[Bug 16230] New: Show tooltip with menu item when fund cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Bug ID: 16230 Summary: Show tooltip with menu item when fund cannot be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P3 Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: fridolin.somers@biblibre.com, gmcharlt@gmail.com, josef.moravec@gmail.com, katrin.fischer@bsz-bw.de, koha-bugs@lists.koha-community.org, magnus@libriotech.no, nengard@gmail.com, tomascohen@gmail.com Blocks: 2310 In Acquisitions -> Funds, if you cannot delete a fund (for instance, because it has children), the "Delete" menu item is grayed out. The menu has the correct markup to trigger a Bootstrap tooltip, but there isn't the correct JavaScript to trigger its display. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 [Bug 2310] Omnibus: Delete grayed out w/out explanation -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50088&action=edit Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50088|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 50108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50108&action=edit Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. NOTE: Before tooltip shows in Chrome, but not bootstrap styling. After, bootstrap styled. The use of _() will add the ability to translate the alert(). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50108|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50109&action=edit [PASSED QA] Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. NOTE: Before tooltip shows in Chrome, but not bootstrap styling. After, bootstrap styled. The use of _() will add the ability to translate the alert(). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org