[Bug 32728] New: ERM - Search header should change to match the section you are in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Bug ID: 32728 Summary: ERM - Search header should change to match the section you are in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: david@davidnind.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com The ERM module search header has three options: Search agreements, Search packages, and Search titles. If you click through the sidebar options (Agreements, Packages, and Titles) the search header doesn't change to reflect the area you are in. If you change the header to another option, for example 'Search titles', then perform a search, the header goes back to 'Agreement search'. To replicate: 1. Enable the ERM module: ERMModule system preference. 2. Go to the ERM module: Home > E-resource management. 3. Select the options from the sidebar menu (Agreements, Packages and Titles), and note that the ERM search header options don't change. 4. Add a minimal agreement, package and title. 5. Change the search header to another option, for example 'Search titles', then perform a search. Note that: - the appropriate sidebar menu option is highlighted, for example: 'Titles' - the search header changes back to 'Agreement search' This was noted as a potential issue when testing bug 32683 - Convert header search tabs to Bootstrap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145897&action=edit Bug 32728: ERM - Update search header depending on navigation Search header should change to match the section you are in. Default is "agreement". If you are in "local titles" or "local packages", the header will be positionned on the relevant tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am not convinced by this patch. Ideally we should embed the search header into the Vue app, but that is much more work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145897|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 146264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146264&action=edit Bug 32728: ERM - Update search header depending on navigation Search header should change to match the section you are in. Default is "agreement". If you are in "local titles" or "local packages", the header will be positionned on the relevant tab. Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to include the test plans in the commit messages :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146264|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147334&action=edit Bug 32728: ERM - Update search header depending on navigation Search header should change to match the section you are in. Default is "agreement". If you are in "local titles" or "local packages", the header will be positionned on the relevant tab. To replicate: 1. Enable the ERM module: ERMModule system preference. 2. Go to the ERM module: Home > E-resource management. 3. Select the options from the sidebar menu (Agreements, Packages and Titles), and note that the ERM search header options don't change. 4. Add a minimal agreement, package and title. 5. Change the search header to another option, for example 'Search titles', then perform a search. Note that: - the appropriate sidebar menu option is highlighted, for example: 'Titles' - the search header changes back to 'Agreement search' 6. Apply patch, run yarn build 7. Verify the search options are now switched when moving between pages Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147482&action=edit Bug 32728: Fix warning There is a couple of wrong things from the previous patch: * There is a warning in the console Firefox [Vue Router warn]: Unexpected error when starting the router: TypeError: document.getElementById(...) is null Chrome [Vue Router warn]: Unexpected error when starting the router: TypeError: Cannot read properties of null (reading 'click') That's because the tabs are not initialized yet, and so the tab is not correctly selected when the app is loaded. * "Search titles" is selected when on packages, and "Search packages" is selected when on titles This patch remove the warning and fix the second problem. However the tab is still wrong when the app is loaded. Will see later if that can be fixed, but it's not trivial at first glance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple enough patch to clean up the warning and get us display correctly most of the time.. we can deal with the initial load issue as a distinct thing in my opinion. PQA on that follow-up from me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- No ERM in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up in master. Please check it is in 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Follow-up is on 22.11.x https://github.com/Koha-Community/Koha/blob/22.11.x/koha-tmpl/intranet-tmpl/... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 [Bug 33422] ERM - Search header should change to match the section you are in -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org