[Bug 30970] New: holdst columns don't match actual columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Bug ID: 30970 Summary: holdst columns don't match actual columns Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The columns selected to hide by default in 'Table settings' for holdst aren't lining up with the actual columns hidden. For example: -In holdst, select columns home_library and current_location to be hidden by default -In the 'Holds waiting' table, see that Patron and Home library are hidden by default. Current location is showing by default. -To hide current_location and home_library by default, I need to select shelving_location and current_location in 'Table settings' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|holdst columns don't match |holdst columns don't match |actual columns |actual columns in 'Holds | |waiting' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks ok for me on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same for me, I think the issue is not in master. Maybe only in 21.11 and other older versions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137618&action=edit Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 [Bug 23678] Cancel holds in bulk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27868 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Lucy Harrison <l.m.harrison@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |l.m.harrison@lboro.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137618|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137625&action=edit Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankyou for the quick signoff Lucy, I've added your signature to the patch itself now too for our history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137625|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 137626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137626&action=edit Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137626|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 137796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137796&action=edit Bug 30970: Add checkbox column to holdst and holdso This patch adds the missing checkbox column to the columns_settings configuration file. The field was added unconditionally to the tables in bug 23678 and then consequently fixed in master as part of bug 27868 which being an ehancement wont be backported. This patch simply lifts the relevant part of the fix from bug 27868 to apply just to the 21.11.x branch. Signed-off-by: Lucy Harrison <l.m.harrison@lboro.ac.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works (I'm taking the two SO to not have to get a 21.11 env), qa script happy, code looks good, same as on master, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- I don't think this requires an update to the documentation, marked Resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org