[Bug 22110] New: Editing adjustments doesn't work for Currencyformat != US
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Bug ID: 22110 Summary: Editing adjustments doesn't work for Currencyformat != US Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 19166 Target Milestone: --- When the CurrencyFormat is set to FR the amount of an adjustment will display with decimal comma. Changing 1,00 to 1,10 will save as 1.00. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 [Bug 19166] Add the ability to add adjustments to an invoice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84028&action=edit Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Mackey Johnstone <mackeyfj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Mackey Johnstone <mackeyfj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84028|0 |1 is obsolete| | --- Comment #2 from Mackey Johnstone <mackeyfj@gmail.com> --- Created attachment 84161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84161&action=edit Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84161|0 |1 is obsolete| | --- Comment #3 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84221&action=edit Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84221|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84881&action=edit Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com> Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix to a silly oversight. No regressions Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22110 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org