[Bug 28066] New: Remove select tag's size attribute where it is 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Bug ID: 28066 Summary: Remove select tag's size attribute where it is 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are quite a few places in the templates where a <select> tag's size attribute is defined as "1." This is not necessary because the default setting for the tag is 1. It becomes a problem when using Bootstrap because Bootstrap's CSS targets <select> tags with a size attribute: select[multiple], select[size] { height: auto; } The goal is to be able to set a comfortable height property to <select> tags which are size 1. Removing the attribute in cases where it is equal to 1 will allow us to consistently size a <select> tag while allowing multiple selects to have the correct size. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119046&action=edit Bug 28066: Remove select tag's size attribute where it is 1 This patch removes the "size" attribute from <select> tags where the value of the attribute is 1. The attribute is unnecessary because the default value when the attribute is undefined is 1. This will allow for more careful sizing of <select> tags without a size attribute while preserving the desired behavior of <select> tags which have a size greater than 1. The patch modifies 83 files but makes the same minor corrections to each. I think examining the diff is sufficent, or testing a representative set of pages: - Administration -> MARC frameworks -> MARC structure -> Edit tag: The "Authorized value" select. - Patrons -> New patron: The "Library" select. - Reports -> Patrons with no checkouts: The "Into an application" selects. If anyone would like help testing any particular template I can follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119046|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119049&action=edit Bug 28066: Remove select tag's size attribute where it is 1 This patch removes the "size" attribute from <select> tags where the value of the attribute is 1. The attribute is unnecessary because the default value when the attribute is undefined is 1. This will allow for more careful sizing of <select> tags without a size attribute while preserving the desired behavior of <select> tags which have a size greater than 1. The patch modifies 83 files but makes the same minor corrections to each. I think examining the diff is sufficent, or testing a representative set of pages: - Administration -> MARC frameworks -> MARC structure -> Edit tag: The "Authorized value" select. - Patrons -> New patron: The "Library" select. - Reports -> Patrons with no checkouts: The "Into an application" selects. If anyone would like help testing any particular template I can follow-up. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I scanned a few of the pages with the change and am happy it doesn't cause any regressions. I then used 'ack' to scan the codebase for missed cases and couldn't spot any. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27514 [Bug 27514] Input boxes change size when selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119049|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119139&action=edit Bug 28066: Remove select tag's size attribute where it is 1 This patch removes the "size" attribute from <select> tags where the value of the attribute is 1. The attribute is unnecessary because the default value when the attribute is undefined is 1. This will allow for more careful sizing of <select> tags without a size attribute while preserving the desired behavior of <select> tags which have a size greater than 1. The patch modifies 83 files but makes the same minor corrections to each. I think examining the diff is sufficent, or testing a representative set of pages: - Administration -> MARC frameworks -> MARC structure -> Edit tag: The "Authorized value" select. - Patrons -> New patron: The "Library" select. - Reports -> Patrons with no checkouts: The "Into an application" selects. If anyone would like help testing any particular template I can follow-up. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119140&action=edit Bug 28066: (QA follow-up) Fix some single quote occurences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added a QA check https://gitlab.com/koha-community/qa-test-tools/-/issues/49 Issue #49 - Forbit select tag's size attribute where it is 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org