[Bug 17947] New: Searching my library first shows the branchcode by the search bar rather than branchname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Bug ID: 17947 Summary: Searching my library first shows the branchcode by the search bar rather than branchname Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org To trigger, turn on syspref "SearchMyLibraryFirst" and go back to OPAC. You'll see by the search bar it now says 'Search (in <branchcode> only), which isn't very user-friendly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 --- Comment #1 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59293&action=edit Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student@wegc | |.school.nz Assignee|oleonard@myacpl.org |caitlingoodger.student@wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59293 Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Review of attachment 59293: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17947&attachment=59293) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +155,4 @@
<label for="masthead_search"> Search [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %] [% IF ( mylibraryfirst ) %] + (in [% LibraryNameTitle %] only)
This is based on the systempreference LibraryName. Perhaps Branches.GetName(mylibraryfirst) is a better choice? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
- (in [% mylibraryfirst %] only) + (in [% LibraryNameTitle %] only)
As M. Tompsett says, [% LibraryNameTitle %] is not going to show you the name of the user's library branch, but the name of the library "system" in a multi-branch situation. The suggestion is to use this instead: (in [% Branches.GetName( mylibraryfirst ) %] only) This uses a template plugin to pull the correct library branch name based on the branchcode output by 'mylibraryfirst' Because this patch doesn't work as expected, I'm setting this to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59293|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59470&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|caitlingoodger.student@wegc |aleishaamohia@hotmail.com |.school.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59470|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59479&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59479|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59570&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59570|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60320&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- String change - will come back to this after release of 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's marked enhancement, but I think it should have always been the name not the code - so I'd say it's more a bug. What do others think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |normal --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've decided to backport this - I think showing the branch name is the correct thing, especially to users in the OPAC. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org