[Bug 5833] New: opacstylesheet not loading on all pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Bug #: 5833 Summary: opacstylesheet not loading on all pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org I’m in the process of customizing some of the styling for our Koha installation and am running into a bit of a snag with styling on these pages: cgi-bin/koha/opac-reserve.pl cgi-bin/koha/opac-user.pl I’m adding the custom css though the remote “opacstylesheet” option, but this file does not get loaded on the pages mentioned above (there may be more pages, I’m not certain). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-03-17 18:42:26 UTC --- I see no problems with those pages when using the opacstylesheet preference. Can you test again? If it's still broken for you perhaps you could pass on the stylesheet for me to test with along with a description of what styles aren't showing up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 16:38:20 UTC --- I take back what I said before about not seeing it. It wasn't until I examined the logic of the template that I realized how the bug worked. The "opacstylesheet" variable isn't getting passed to the template on the login page. Unfortunately I don't understand why. The OPACUserCSS variable is working fine, for instance. What's different about opacstylesheet? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-28 16:39:45 UTC --- This is probably a problem with C4::Auth. I will take a look at it. Regards, Jared -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 16:53:34 UTC --- Created attachment 3470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3470 Proposed fix Jared is right, and I just wasn't looking in the right place in Auth.pm. There is a separate section in which template variables are declared for the login page. The opacstylesheet variable was missing from that section. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-28 16:56:32 UTC --- too bad we're late on submitting our patches: i've fixed (with the same fix) on march 17th. So I confirm the problem and the fix (just in case = see branch am123/CRI/MT6039 on git.biblibre.com) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 08:59:15 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 Mark Gavillet <mark.gavillet@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |mark.gavillet@ptfs-europe.c | |om Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5833 --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-07 10:50:56 UTC --- This bug is mentioned in: Fix for Bug 5833, opacstylesheet not loading on all pages http://lists.koha-community.org/pipermail/koha-patches/2011-March/014283.htm... Fix for Bug 5833, opacstylesheet not loading on all pages http://lists.koha-community.org/pipermail/koha-patches/2011-March/014281.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org