https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 130703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130703&action=edit Bug 30118: Make holds_block_checkin in SIP behave like in Koha interface. In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. This patch does the same in SIP: the return is blocked when holds_block_checkin is enabled and there is a hold on a specific item and this is the very item being returned. Test plan: The following behavior is expected in SIP: - An item is returned, and there is a reservation on record-level: block - An item is returned, and there is a reservation on this very item: block - An item is returned, and there is a reservation on another item: allow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #3 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, I tried on my kohadevbox with ./sip_cli_emulator.pl I've followed the test plan and it works: For a reservation at a biblio-level, for the first item returned that is going to fulfill the reservation : it is blocked For a reservation at a biblio-level, if an item is already waiting for to fulfill the reservation, if you checkin another item : it is not blocked For a reservation at an item level, if you checkin another item : it is not blocked For a reservation at item level, if you checkin the very item : it is blocked Sonia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132626|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132656&action=edit Bug 30118: Make holds_block_checkin in SIP behave like in Koha interface. In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. This patch does the same in SIP: the return is blocked when holds_block_checkin is enabled and there is a hold on a specific item and this is the very item being returned. Test plan: The following behavior is expected in SIP: - An item is returned, and there is a reservation on record-level: block - An item is returned, and there is a reservation on this very item: block - An item is returned, and there is a reservation on another item: allow Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.