http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26902&action=edit Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26902|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26904&action=edit [SIGNED OFF] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Without CAS properly set up, the URL will actually be empty for the CAS' click here to login link. COMMENT: Though this does do what it says it does, would it not be better to redirect to the opac-user page and get the old page loaded up as before, so not just CAS but all potential authentication mechanisms will work? Increasing the size of the modal seems to defeat the purpose of the modal, in my opinion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26904|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26931&action=edit [PASSED QA] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Without CAS properly set up, the URL will actually be empty for the CAS' click here to login link. COMMENT: Though this does do what it says it does, would it no be better to redirect to the opac-user page and get the old page loaded up as before, so not just CAS but all potential authentication mechanisms will work? Increasing the size of the modal seems to defeat the purpose of the modal, in my opinion. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |fridolyn.somers@biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch does not work. The variable CasServerUrl is always empty. It's a major problem for CAS users. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@biblibre.co |fridolyn.somers@biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Fridolin, your patch is much more consistent than mine! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27628|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27647&action=edit [PASSED QA] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like: https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Normal login still works with/without CAS. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.