[Bug 23392] New: Support MARC21 indicators for private note fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Bug ID: 23392 Summary: Support MARC21 indicators for private note fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org MARC21 indicates that several notes fields (541,542,561,583,590) are 'private' if first indicator is 0 and should not display on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91851&action=edit Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mkstephens@lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Passed test. Works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91851|0 |1 is obsolete| | --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 94632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94632&action=edit Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 --- Comment #4 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 94633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94633&action=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 --- Comment #5 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 94634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94634&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 94632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94632 Bug 23392: Don;t display private notes in MARC 21 Review of attachment 94632: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23392&attachment=94632) ----------------------------------------------------------------- ::: Koha/Cache.pm @@ +249,4 @@
? $set_sub->( $key, $value ) : $self->{$cache}->set( $key, $value ); } + warn $expiry;
Should be removed - I'll amend the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94632|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94642&action=edit Bug 23392: Don;t display private notes in MARC 21 To test: 1 - Add some notes to a record in fields 541,542,561,583,590 2 - Ensure all of these are visible in the frameworks 3 - Note they appear in the 'Title notes'/'Description' tabs on OPAC/Staff client 4 - Mark first indicator '0' on all notes 5 - They still display 6 - Apply patch 7 - Notes no longer show on OPAC 8 - Notes still show on Staff client 9 - prove -v t/Biblio/GetMarcNotes.t Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23392 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org