[Bug 32323] New: Correct focus state of some DataTables controls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Bug ID: 32323 Summary: Correct focus state of some DataTables controls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 Created attachment 144166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144166&action=edit Screenshot of the button focus state If you use the tab key to navigate through DataTables controls, some of the buttons have a style which is out of place in our design. See screenshot attached. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144168&action=edit Bug 32323: Correct focus state of some DataTables controls This patch makes changes to the style of some DataTable controls in order to make hover, active, and focus states more consistent. To test, apply the patch and rebuild the staff interface css. View a page that has a DataTable showing controls like "Columns," "Export," and "Configure." For example: Saved reports, Libraries, Overdues. - Click the DataTables search form to put cursor focus there. - Use the tab key to move through the next buttons. - The style should now be more consistent with the appearance of other similar buttons in the staff client. - Test with and without text in the search filter. - Test pages which don't have the full set of controls, e.g. the table of of a patron's checkouts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144168|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144179&action=edit Bug 32323: Correct focus state of some DataTables controls This patch makes changes to the style of some DataTable controls in order to make hover, active, and focus states more consistent. To test, apply the patch and rebuild the staff interface css. View a page that has a DataTable showing controls like "Columns," "Export," and "Configure." For example: Saved reports, Libraries, Overdues. - Click the DataTables search form to put cursor focus there. - Use the tab key to move through the next buttons. - The style should now be more consistent with the appearance of other similar buttons in the staff client. - Test with and without text in the search filter. - Test pages which don't have the full set of controls, e.g. the table of of a patron's checkouts. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Where is coming from #ADADAD? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144179|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144495&action=edit Bug 32323: Correct focus state of some DataTables controls This patch makes changes to the style of some DataTable controls in order to make hover, active, and focus states more consistent. To test, apply the patch and rebuild the staff interface css. View a page that has a DataTable showing controls like "Columns," "Export," and "Configure." For example: Saved reports, Libraries, Overdues. - Click the DataTables search form to put cursor focus there. - Use the tab key to move through the next buttons. - The style should now be more consistent with the appearance of other similar buttons in the staff client. - Test with and without text in the search filter. - Test pages which don't have the full set of controls, e.g. the table of of a patron's checkouts. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323 Bug 32323 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org