http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25461&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25461|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25475&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25475|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25488&action=edit Bug 11793 - Use validation plugin when creating new item type The page for adding a new item type includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Item types -> New item type. Try submitting the form with the following error conditions: - Missing item type - Missing description - A non-number in the "rental charge" field These errors should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing item type should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11793 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.