[Bug 24485] New: Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Bug ID: 24485 Summary: Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Prior to 19.05, if a library had the system preference, AllowHoldPolicyOverride, set to Allow, a staff member could place more than one item specific hold on a record although the circulation rule for "Holds per Record" was set to 1. Currently, in 19.05.06, the ability to override such a hold has been removed. The process stops at the portion where the second item level hold is about to be placed, however, the Place Hold (at the bottom) button is Greyed out. This means Koha is allowing the staff member to choose the item and then not letting the process to complete. A library with the system preference set to ALLOW for AllowHoldPolicyOverride should be allowed to override a hold rule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- A broader issue to this bug seems to also stem from the system preference "maxreserves". In the example below, AllowHoldPolicyOverride is set to Allow, a staff member should be able to override the Holds per Record value and also the MaxReserves system preference, however, Koha is again stopping the override from happening if it hits this system preference MaxREserves. 1. AllowHoldPolicyOverride- set to Allow 2. Circulation Rule - 500 Holds Per Record allowed 3. MaxReserve system preference set to 5. 4. Patron has 6 holds - 1 of those holds is on 1 item of a bib record. 5. Staff can not place a second item level hold on a record due to this sys pref MaxReserve value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98032&action=edit Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master Severity|minor |normal CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98032|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98038&action=edit Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98038|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98394&action=edit Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code scans well and does whats expected.. simple improvement and passes qa scripts.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sys Pref |AllowHoldPolicyOverride |AllowHoldPolicyOverride |should allow Staff to |will not Staff override a |override the Holds Per |Holds Per Record Rule |Record Rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org