[Bug 6331] New: Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Bug #: 6331 Summary: Obsolete marc column in deleteditems Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org There is a difference between "items" and "deleteditems" tables in "kohastructure.sql" : "deleteditems" has a field "marc" not existing in "items". This columns appears to be obsolete. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug is still valid in master as of 3.12 beta1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11275 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 23055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23055&action=edit Bug 6331 - Obsolete marc column in deleteditems See commit message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23055|0 |1 is obsolete| | CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23230&action=edit [PATCH][SIGNED OFF] Bug 6331 - Obsolete marc column in deleteditems -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Test : - suppressing an item, checking the deleted item is properly stored in deleteditems table - checking the column marc has been deleted from deleteditems table I sign off Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 23256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23256&action=edit Supplementary patch The main patch removes the field but DelItem still attempts to populate it supplementary patch to remove that -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch needs a followup to remove any references in code to the marc column in deleteditems. I spotted one in C4/Items.pm at least. I'm also wondering if this affects the output of tools/export.pl (or rather assume it affects) so that will need correcting to. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like Colin did the first followup I wanted whilst I was failing.. can someone take care of the second one? I'll then nudge Katrin to do QA as with Colin's input I no longer can.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting back to Needs Signoff, I've gone through the code and don't think the third followup is required.. I believe the marc column is grabbed from biblioitems in the join so this isn't a regression. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23256|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 23316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23316&action=edit Bug 6331 Do not populate marc in deleted items This is supplementary to the main patch for bug 6331. Having removed the attribute marc from items DelItem should not populate it Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23316|Bug 6331 Do not populate |[SIGNED-OFF]Bug 6331 Do not description|marc in deleted items |populate marc in deleted | |items --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Comment on attachment 23316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23316 [SIGNED-OFF]Bug 6331 Do not populate marc in deleted items Tested by applying the 2 patches, deleting an item and check that item is moved from table items to table deleteditems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- hello I suspect this line for copying marc column was only here to update the timestamp of deleteditems table. With your patch, is the timestamp still updated? Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to mathieu saby from comment #11)
hello I suspect this line for copying marc column was only here to update the timestamp of deleteditems table. With your patch, is the timestamp still updated?
Mathieu
Just jumping in this discussion: But I would not like to loose the timestamp in deleteditems or deletedbiblio.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #13 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to mathieu saby from comment #11) In my test, timestamp value is copied from table items. It does not get the current timestamp. @M. de Rooy : If timestamp is not updated, how do we know the date/time of deletion ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Fridolin SOMERS from comment #13)
(In reply to mathieu saby from comment #11) In my test, timestamp value is copied from table items. It does not get the current timestamp.
@M. de Rooy : If timestamp is not updated, how do we know the date/time of deletion ?
I made some reports recently on my Koha (v 3.11). Timestamp of deleteditems were updated when we delete them. So this behavior must be keep in 3.14 :-) Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 23320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23320&action=edit Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2011-09-09 15:30:21 | +---------------------+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2013-12-05 15:33:20 | +---------------------+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Set as need signoff for 3rd patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23320|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 23356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23356&action=edit [SIGNED-OFF] Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2011-09-09 15:30:21 | +---------------------+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2013-12-05 15:33:20 | +---------------------+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Everything now works as advertised for me.. signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23230|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23725&action=edit Bug 6331 - Obsolete marc column in deleteditems There is a difference between "items" and "deleteditems" tables in "kohastructure.sql" : "deleteditems" has a field "marc" not existing in "items". This patch removes this obsolete column. === Test : - suppressing an item, checking the deleted item is properly stored in deleteditems table - checking the column marc has been deleted from deleteditems table Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23316|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23726&action=edit Bug 6331 Do not populate marc in deleted items This is supplementary to the main patch for bug 6331. Having removed the attribute marc from items DelItem should not populate it Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23356|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23727&action=edit Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2011-09-09 15:30:21 | +---------------------+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +---------------------+ | timestamp | +---------------------+ | 2013-12-05 15:33:20 | +---------------------+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch set passes koha-qa.pl, works as advertised! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #22 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolin and Colin! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.2. (created version 3.14.01.004) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org