[Bug 14987] New: patron card creator not displaying correct cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Bug ID: 14987 Summary: patron card creator not displaying correct cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Actually, I'm not entirely sure what the context of "cardnumber" is on edit-batch - is it the number of the card being printed? Is it supposed to be the cardnumber of the borrower? I admit to not having the chance to really dig up what it's supposed to be but it doesn't really make sense to me as it stands. I think it should either be the cardnumber of the borrower (i.e. the barcode that would be printed) or explicitly labelled something that is not "cardnumber" if it's something else. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Card number is the position number in the batch. It comes from: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt Line 215 [% SWITCH header_field.field_label -%] [% CASE "Card Number" -%] <th>Card number</th> ^----------------------- patroncards/edit-batch.pl Line 50 my $display_columns = [ {_card_number => {label => 'Card Number', (...) ^---------------------- Line 138 get_card_summary ^---------------------- C4/Creators/Lib.pm get_card_summary: This function returns an arrayref whose elements are hashes containing the label_ids of current cards along with the item count Line 367 : my $card_number = 0; (...) foreach my $item (@{$params{'items'}}) { $card_number++; (...) my $card_summary->{'_card_number'} = $card_number; Fazit: Quick string fix would be to change edit-batch.cc More comprensible / sustainable fix would be to change edit-batch.pl and Lib.pm as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #2 from Marc Véron <veron@veron.ch> --- Typo: Quick string fix would be to change edit-batch.cc ^^ edit-bach.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Ah right. Well that's still a little silly. I'm doing heaps of stuff in there atm, maybe I'll fix it. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #4 from Marc Véron <veron@veron.ch> --- Some more findings: In label batches, the column is called 'Label number', I think the internals are similar to patron cards. The patron cards and labels are printed in this order. It would be a good idea to have the same column name for both. Maybe something like 'Item Number'. 'Position' or 'Batch position' would collide with the meaning of 'Position' while exporting labels: "Enter starting label position (PDF)" i.e. the position where the first batch item will be printed on the paper / printing form (see Bug 8796). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Hm, but you can't change it, and it is basically the order the items are added... Idk, I suppose I'm questioning why we need to display it at all. It would, in fact, be good to make it consistent between the label creator and patron card creator. That is if we don't remove the display entirely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #6 from Marc Véron <veron@veron.ch> --- I also was thinking about not displaying this column. Hmm, we can sort the colums e.g. alphabetically by name (in the table only, not for printing), so it might be needed to switch back to the order 'how I added items'. It would be a big enhancement (and quite a task) - to have te possibility to print in different orders - to be able to move an item inside the 'added' batch position Hmm, at the moment I propose to change the template files only (string change for the headers to avoid user confusion) and to postpone the rest. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org