[Bug 15288] New: 404 page: Remove string splitting by html tags to avoid weird translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bug ID: 15288 Summary: 404 page: Remove string splitting by html tags to avoid weird translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr On the Koha Error 404 page the following sentence is not properly translatable due to string splitting: To report a broken link or any other issue, please send an email to the Koha Administrator In German, it results in: Um diesen Fehler zu melden, können Sie E-Mail an den Koha-Administrator. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | Component|I18N/L10N |Architecture, internals, | |and plumbing Summary|404 page: Remove string |Staff error pages: Code |splitting by html tags to |duplication removal and |avoid weird translations |better translatability --- Comment #1 from Marc Véron <veron@veron.ch> --- The problem is related to all error pages (400, 401, 402, 403, 404 500). Changing Bug title to "Staff error pages: Code duplication removal and better translatability" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45354&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45354|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 45355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45355&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45355|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 45356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45356&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45356|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 45357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45357&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files (Amended to fix a typo) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |In Discussion --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Why you leave 405.tt even though you don't touch 405.pl?
<li>To report a broken link or any other issue, please contact the Koha >Administrator <a href="mailto:[% admin %]">Email</a></li>
I think (IMHO) that you can change "Email" for "Email the administrator" or something like that. Another thing is that the OPAC has the same error pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff error pages: Code |Error pages: Code |duplication removal and |duplication removal and |better translatability |better translatability -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 45396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45396&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45396|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 45422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45422&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 45424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45424&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45422|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45425&action=edit [SIGNED-OFF]Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45424|0 |1 is obsolete| | --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45426&action=edit [SIGNED-OFF]Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Files removed, new errorpage.tt added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch could annoy people who have customized their template error pages. I don't know how popular is it, but I am not confident to pass QA on it without any feedbacks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you ask on koha[-devel] or irc please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #14 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #13)
Could you ask on koha[-devel] or irc please?
http://irc.koha-community.org/koha/2015-12-10#i_1766309 http://irc.koha-community.org/koha/2015-12-10#i_1766411 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think we will always have changes happen that will have people rework their customizations a bit. Changes make sense to me on first glance, so in my opinion I wouldn't block it. Jonathan, do you have a specific change/use case in mind? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #15)
Hm, I think we will always have changes happen that will have people rework their customizations a bit. Changes make sense to me on first glance, so in my opinion I wouldn't block it. Jonathan, do you have a specific change/use case in mind?
If a sys admin has customized the different error pages, the changes will be erased. I agree that it's the same for all the specific changes made in templates, but it is much more easier to customize error pages. With only 1 template to drive the different error pages, it will be harder to customize them. If nobody used to customize them, so let's refactore them. I have just told that I am not aware of the different practices and maybe it's not worth doing this change if it will overload sys admins in the next version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I don't quite understand since it would have never occurred to me to customize them (apart from CSS/Javascript). I have checked the code - they will still show a unique class for the different errors in the body tag - won't that be enough to customize? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #18 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #14)
(In reply to Jonathan Druart from comment #13)
Could you ask on koha[-devel] or irc please?
http://irc.koha-community.org/koha/2015-12-10#i_1766309 http://irc.koha-community.org/koha/2015-12-10#i_1766411
I asked on IRC devel list as well: http://lists.koha-community.org/pipermail/koha-devel/2015-December/042131.ht... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #19 from paxed <pasi.kallinen@pttk.fi> --- Best practice would probably be to use the explicitly numbered error code page template if it exists. Eg. If errors/400.tt exists, then use that for error 400, otherwise use errors/errorpage.tt This way it will not clobber any local modifications. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure we should build in hooks for template modifications like this - we have a template system if people really really want to do this, with a fallback to the standard template, already. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree, if people have modified template files (which the error pages are) and haven't either 1, used any version control, or 2 backed up a copy I don't think we need to care. It's the same as editing any of the files IMHO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #22 from Marc Véron <veron@veron.ch> --- What is now the status of this bug - can we switch back to Signed off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- imo the argument of adjusted error templates is not really valid; as Chris and Katrin already pointed out, this holds for any template. So I would not oppose these changes. But I think the new template text needs more attention. Two examples. Perhaps check text changes with a native speaker? 400: Koha is pointed an invalid link. Is this valid English? 402: Same string. These are separate http status codes. They should not have the same message. Could you try to keep close to the original messages for http statuses? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #24 from Marc Véron <veron@veron.ch> --- Search for better wording for 400 / 402: See: https://tools.ietf.org/html/rfc2616#section-10.4 10.4.1 400 Bad Request The request could not be understood by the server due to malformed syntax. The client SHOULD NOT repeat the request without modifications. 10.4.2 401 Unauthorized The request requires user authentication. (...) 10.4.3 402 Payment Required This code is reserved for future use. 10.4.4 403 Forbidden The server understood the request, but is refusing to fulfill it. Authorization will not help (...) 10.4.5 404 Not Found The server has not found anything matching the Request-URI. (...) This status code is commonly used when the server does not wish to reveal exactly why the request has been refused, or when no other response is applicable. 10.5.1 500 Internal Server Error The server encountered an unexpected condition which prevented it from fulfilling the request. Porposals for the template: 400 (New wording): <li>The request could not be understood by the server due to malformed syntax.</li> 401 (no changes to patch): <li>You are trying to access a link that you're not authorized to see.</li> <li>Try logging in to the catalog.</li> 402 (remove): It seems that 402 is not used (git grep '402.pl') Can be removed. 403 (no changes to patch): <li>You are forbidden for some reason to see this page.</li> 404 (no changes to patch): <li>You made use of an external link to a catalog item that is no longer available.</li> <li>You followed an outdated link e.g. from a search engine or a bookmark.</li> <li>You tried to access a page that needs authentification.</li> <li>An internal link in our catalog home page is broken and the page does not exist.</li> 405: <li>An internal error occurred while processing your request.</li> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14573 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #25 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc you can use the paragraphs from bug 14573, like Aleisha proposes. What do you think about it, Marcel and Aleisha? Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #26 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Héctor Eduardo Castro Avalos from comment #25)
Hi Marc you can use the paragraphs from bug 14573, like Aleisha proposes. What do you think about it, Marcel and Aleisha?
Regards
I think it is a good idea to use the messages from Bug 14573 because then they will be consistent with the Intranet error messages (see Bug 14574) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #27 from Marc Véron <veron@veron.ch> --- Hi Aleisha, as a native speaker, would you have time to do a follow up with your wording? - That would be great. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #28 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #27)
Hi Aleisha, as a native speaker, would you have time to do a follow up with your wording? - That would be great.
Have you had a look at my error messages from Bug 14573? I think this bug is basically a duplicate of 14573. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #29 from Marc Véron <veron@veron.ch> --- Created attachment 46303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46303&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Marc Véron <veron@veron.ch> --- Needs sign-off for the followup (Better wording). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46303|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 46316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46316&action=edit [SIGNED-OFF] Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Having a look now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45425|0 |1 is obsolete| | Attachment #45426|0 |1 is obsolete| | Attachment #46316|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 46322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46322&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 46323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46323&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Files removed, new errorpage.tt added Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 46324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46324&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: Replaced following reasons by 'the following reasons'. Reads better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Thanks for the follow-up, Marc. Looks good to me now. No blockers, but maybe for future improvement: [1] For more consistency, it would be nice to have the same reasons for an error listed on opac and intranet. Perhaps from a shared include or so? At this time the opac is more specific. [2] I would not mind listing the original status message after Error <number> on the same line. Something like Error 403 Forbidden or Error 404 Not Found [3] Perhaps removing 402 is better than saying Invalid link. We do not use it in Koha, it is supposed to mean Payment required. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #37 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marcel de Rooy from comment #36)
[1] For more consistency, it would be nice to have the same reasons for an error listed on opac and intranet. Perhaps from a shared include or so? At this time the opac is more specific.
This is exactly why I suggested using the error messages from Bug 14573 which needed signing off, because the error messages would then be consistent with those on Bug 14574, which has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #38 from Aleisha Amohia <aleishaamohia@hotmail.com> --- *** Bug 14573 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org