[Bug 33066] New: We need a KohaTable Vue component
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Bug ID: 33066 Summary: We need a KohaTable Vue component Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 23991 The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147352&action=edit Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147353&action=edit Bug 33066: Fix dt - no need to reselect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147354&action=edit Bug 33066: Add colvis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- still needs to be done: * column filter needs to be dropdown list when needed (see preDrawCallback in AgreementsList.vue) * Remove useless code from AgreementsList.vue * Fix UI display when using ColVis * Improve "actions", it's really not nice how it's done (the -1 especifically) * Confirm default_search is working * Confirm default_filters is working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan!, Great, I'll take a look at this as soon as I can. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23991 |32991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 [Bug 32991] Improve our Dialog component and remove routes for deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147352|0 |1 is obsolete| | Attachment #147353|0 |1 is obsolete| | Attachment #147354|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147692&action=edit Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147693&action=edit Bug 33066: Fix dt - no need to reselect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147694&action=edit Bug 33066: Add colvis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #9 from Agustín Moyano <agustinmoyano@theke.io> --- When I fixed the dependency from bug 23991 to bug 32991 patches no longer applied, so I rebased it. The little code I could see it's ok and works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #10 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147713&action=edit Bug 33066: Fix search by vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add import sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #10)
Created attachment 147713 [details] [review] Bug 33066: Fix search by vendor
Can you detail a bit? This is not working as expected: the empty table should not be displayed if there are no agreements, but the "There are no agreements defined" message instead. And so we need the "Loading..." back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The table is not loading with this last patch, I get "Uncaught TypeError: row.vendor is null" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147713|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147846&action=edit Bug 33066: Fix "Loading..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147847&action=edit Bug 33066: Reintroduce column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147848&action=edit Bug 33066: Fix name display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147849&action=edit Bug 33066: Remove build_datatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147850&action=edit Bug 33066: Embed vendor and retrieve vendor name from the request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147851&action=edit Bug 33066: Remove duplicate 'Actions' column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147852&action=edit Bug 33066: Fix default_search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147853&action=edit Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147855&action=edit Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147856&action=edit Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147857&action=edit Bug 33066: Fix agreement name in delete confirmation dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147858&action=edit Bug 33066: Use KohaTable for LicensesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147858|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147862&action=edit Bug 33066: Use KohaTable for LicensesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147865&action=edit Bug 33066: Restore HTML escaping And we add a render function that will escape by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am done for today, feel free to have a look. I will continue tomorrow and adjust the other tables. Basically the diff that is needed can be seen on "Bug 33066: Use KohaTable for LicensesList". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147692|0 |1 is obsolete| | Attachment #147693|0 |1 is obsolete| | Attachment #147694|0 |1 is obsolete| | Attachment #147846|0 |1 is obsolete| | Attachment #147847|0 |1 is obsolete| | Attachment #147848|0 |1 is obsolete| | Attachment #147849|0 |1 is obsolete| | Attachment #147850|0 |1 is obsolete| | Attachment #147851|0 |1 is obsolete| | Attachment #147852|0 |1 is obsolete| | Attachment #147853|0 |1 is obsolete| | Attachment #147855|0 |1 is obsolete| | Attachment #147856|0 |1 is obsolete| | Attachment #147857|0 |1 is obsolete| | Attachment #147862|0 |1 is obsolete| | Attachment #147865|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147902&action=edit Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147903&action=edit Bug 33066: Fix dt - no need to reselect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147904&action=edit Bug 33066: Add colvis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147905&action=edit Bug 33066: Fix "Loading..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147906&action=edit Bug 33066: Reintroduce column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147907&action=edit Bug 33066: Fix name display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147908&action=edit Bug 33066: Remove build_datatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147909&action=edit Bug 33066: Embed vendor and retrieve vendor name from the request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147910&action=edit Bug 33066: Remove duplicate 'Actions' column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147911&action=edit Bug 33066: Fix default_search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147912&action=edit Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147913&action=edit Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147914&action=edit Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147915&action=edit Bug 33066: Fix agreement name in delete confirmation dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147916&action=edit Bug 33066: Use KohaTable for LicensesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147917&action=edit Bug 33066: Restore HTML escaping And we add a render function that will escape by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147918&action=edit Bug 33066: Restore filter by mine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased patches + last patch is fixing the "additional filters" we are passing to KohaTable. I have tried several things and it's the only way that makes things work, it reads weird and ugly however. Suggestions welcomed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147921&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackagesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147922&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147923&action=edit Bug 33066: Fix style - FIXME This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #48)
Created attachment 147923 [details] [review] Bug 33066: Fix style - FIXME
This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied.
This patch is not working, I don't understand what's happening! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147925&action=edit Bug 33066: Use KohaTable for EHoldingsLocalTitlePackagesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147921|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147926&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackagesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #51)
Created attachment 147926 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackagesList
This is not working because we were not using kohaTable from this component, but dataTable => not ajax but data from array directly. We could adjust our KohaTable Vue component to deal with that, but that's for another day... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147928&action=edit Bug 33066: Use KohaTable for EHoldingsLocalTitlesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147957&action=edit Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147960&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #55) This needs the last patch from 32983 to apply correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch up-to-date with master is at https://gitlab.com/joubu/Koha/-/commits/bug_33066 There are 2 components left: EHoldingsEBSCOPackageTitlesList and EHoldingsEBSCOTitlesList I won't be able to finish this before the next two weeks unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147971&action=edit Bug 33066: Restore '(#id)' to lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #59 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147972&action=edit Bug 33066: Fix agreements and licenses cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #60 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I want to pick this up but not sure if I have the time to dedicate to it in the next few days. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147922|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ready for signoff, the patches are on the remote branch at https://gitlab.com/joubu/Koha/-/commits/bug_33066 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've added a couple of follow-ups to the remote branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148718&action=edit Bug 33066: Fix table style Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #64 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Joubu the above patch sits on top of https://gitlab.com/joubu/Koha/-/commits/bug_33066 I believe it fixes the styling problem with the related resources table not going full width. Important: Please test EBSCO well, I have not tested EHoldingsEBSCOPackageTitlesList because I lack the EBSCO credentials at this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I have tested and reviewed this code and everything seems to be working nicely. Not 100% familiarized with the previous datatables code so can't say there is 100% feature parity but it seems to be. I think this is ready for squashing and sign-off at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Pedro Amorim from comment #63)
Created attachment 148718 [details] [review] Bug 33066: Fix table style
Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling
Added to the remote branch, thanks! Remote branch rebased and some patches have been squashed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #49)
(In reply to Jonathan Druart from comment #48)
Created attachment 147923 [details] [review] [review] Bug 33066: Fix style - FIXME
This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied.
This patch is not working, I don't understand what's happening!
The patch from Pedro is fixing both problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #68 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Signed-off from me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #69 from Agustín Moyano <agustinmoyano@theke.io> --- Signed-off from me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Added your signed-off-by lines to the remote branch, thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149158&action=edit Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) Bug 33066: Fix agreement name in delete confirmation dialog Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149159&action=edit Bug 33066: Fix dt - no need to reselect Bug 33066: (follow-up) Fix dt - no need to reselect Patron search result table was not displayed correctly Uncaught TypeError: this.on is not a function Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149160&action=edit Bug 33066: Add colvis Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149161&action=edit Bug 33066: Fix "Loading..." Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149162&action=edit Bug 33066: Reintroduce column filters Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149163&action=edit Bug 33066: Fix name display Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149164&action=edit Bug 33066: Remove build_datatable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149165&action=edit Bug 33066: Embed vendor and retrieve vendor name from the request Bug 33066: (follow-up) Embed vendor and retrieve vendor name from the request It needs "Bug 32923: Allow to embed user_roles for agreements" Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149166&action=edit Bug 33066: Remove duplicate 'Actions' column Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149167&action=edit Bug 33066: Fix default_search Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149168&action=edit Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149169&action=edit Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149170&action=edit Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149171&action=edit Bug 33066: Use KohaTable for LicensesList Bug 33066: (follow-up) Use KohaTable for LicensesList There was a mismatch, we can embed the whole vendor object info. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149172&action=edit Bug 33066: Restore HTML escaping And we add a render function that will escape by default Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149173&action=edit Bug 33066: Restore filter by mine Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149174&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackagesList Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149175&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149176&action=edit Bug 33066: Use KohaTable for EHoldingsLocalTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #90 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149177&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #91 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149178&action=edit Bug 33066: Restore '(#id)' to lists Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #92 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149179&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOPackageTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #93 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149180&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #94 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149181&action=edit Bug 33066: Remove useless use of useDataTable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #95 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149182&action=edit Bug 33066: Fix cypress tests Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #96 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149183&action=edit Bug 33066: Fix table style Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling JD: following commit has been squashed. Patch from Pedro is fixing the FIXME """ Bug 33066: Fix style - FIXME This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied. There is also the "green tick" (fa-check-square-o) that is not on the same line https://snipboard.io/jma923.jpg """ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles/packages found locally" only displayed when we click the submit button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33443 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles found locally" not displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #97 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this broke Jenkins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #99 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #98)
It looks like this broke Jenkins.
Hey, we need the images rebuilt with the new deps. thanks for reporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 [Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/core at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ERM is totally broken for me :( I have tried it all: git pull, ktd down, ktd pull, ktd up, etc. But I am still stuck with that and no table will display: Source map error: Error: unsupported protocol for sourcemap request webpack://koha/node_modules/vue-select/dist/vue-select.js.map Resource URL: webpack://koha/./node_modules/vue-select/dist/vue-select.js? Source Map URL: vue-select.js.map [Vue warn]: Unhandled error during execution of render function at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ] options= Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {…}, <handler>: {…} } options= Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {…}, <handler>: {…} }
at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 Uncaught (in promise) TypeError: currentRenderingInstance is null renderSlot webpack://koha/../node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3092 render VueJS renderComponentRoot webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1028 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5730 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5737 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5810 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:514 promise callback*queueFlush webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:406 queueJob webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:400 effect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5842 triggerEffect webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:430 triggerEffects webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:420 trigger webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:392 set webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:559 set webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3311 beforeRouteEnter webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 promise callback*beforeRouteEnter/< webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 callWithAsyncErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:293 job webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1915 flushPostFlushCbs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:467 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:521 erm_22.1200019.js line 3481 > eval:3092:9
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed by a yarn install before yarn build. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 [Bug 33529] Increase flexibility of action buttons in tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Bug 33066 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Status|Pushed to master |Needs documenting --- Comment #102 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst this is most certainly an enhancement.. it's an important architectural one for ERM. I've decided to overrule the decision made not to backport as I believe, especially as this is an LTS release, we need it to ensure we can continue to maintain ERM going forward for the rest of the maintanence period. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #105 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ERM |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 [Bug 33973] Sorting broken on ERM tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 [Bug 35919] Add record sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 [Bug 37395] Cannot hide columns in ERM tables -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org