https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 57402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57402&action=edit Bug 17602 : Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Testing this with the OneClick digital credentials shared between ByWater/Catalyst I am not able to get any search results, I either get an error or a constant spin - does this work in your testing currently? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57402|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 60855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60855&action=edit Bug 17602 : Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Bug 17602 depends on bug 16034, which changed state. Bug 16034 Summary: Integration with OverDrive Patron API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Basic functionality seems to be working right now, a couple issues: 1 - We should be able to get results without being signed in - this would mirror functionality for other sources 2 - The account page should offer a 'logout' option 3 - When no items are checked out or on hold the account tab should not display the headings in the account tab 4 - Image links in OneClick results lead no where, ideally these would point out to the oneclick site for the library 5 - It would be nice to have a few more details on the results page if possible -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60855|0 |1 is obsolete| | --- Comment #12 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 62248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62248&action=edit Bug 17602 Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Searchign when nit signed in works, but I am required to sign in once I click the results link While my acocunt works on the oneclick site I am getting this error on results page: Invalid user_id nick@bywatersolutions.com Invalid Basic Token or permission denied at /usr/local/share/perl/5.20.2/WebService/ILS.pm line 748. at /home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 61. When I click the image on the results page it points to: http://localhost:8080/cgi-bin/koha/XXX User tab either has error above or: Bad Request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63392|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 63778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63778&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63780|0 |1 is obsolete| | --- Comment #20 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 63857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63857&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63779|0 |1 is obsolete| | --- Comment #21 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 64070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64070&action=edit Bug 17602 Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron OneClickDigital* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64070|0 |1 is obsolete| | --- Comment #23 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 64095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64095&action=edit Bug 17602 Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron OneClickDigital* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64099&action=edit Bug 17602 Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron OneClickDigital* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen@gmail.com --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi everyone here. I tested this with some credentials Nick gave me. I have a couple observations about this one. Important ========= - I first tested opac-oneclick-search.pl using the q= query param. That way I found stuff in Oneclick. The searched on the main opac search for a term I knew should give results (q=1776), and I got (the first time) "Error searching OneClickDigital collection: Not Found". I then reloaded the results page, and got "Found 1 results in OneClickDigital collection". This one seemed ok - When clicking in the '1 results' link, I got a red message "Error searching OneClickDigital collection: Not Found", on reloading, I got the search results for 1776. => FAIL: It seems there's a problem on the first query, or a throttling stuff getting in the middle. Moderate ======== => FAIL: The search results on opac-oneclick-search.pl have a different styling than Koha's search results. They look nicer, but I think the same XSLT's shold be used. I understood that this is a transition until this search results are displayed inline along with the regular (local) search results. I wouldn't say the second item is a blocker, but it might be a reason for others to vote against its inclusion. Minor ===== - Another (minor) thing I would consider changing is the wording for the sysprefs description. I think they should clearly match what Oneclick provides the user to configure Koha (LibraryID vs. library #) - Warnings are logged: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/WebService/ILS/OneClickDigital/PartnerPatron.pm line 58. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 73. QA scripts ========== The QA scripts complain about oneclick-checkout.inc => FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/oneclick-checkout.inc FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64099|0 |1 is obsolete| | --- Comment #30 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 65988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65988&action=edit Bug 17602 RecordedBooks Integration to Koha - sysprefs and Koha::ExternalContent::RecordedBooks Koha::ExternalContent::RecordedBooks - a wrapper around WebService::ILS::RecordedBooks::PartnerPatron RecordedBooks* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64100|0 |1 is obsolete| | --- Comment #31 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 65989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65989&action=edit Bug 17602 RecordedBooks integration to Koha - OPAC Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64098|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66341&action=edit Bug 17602 Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65989|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66343&action=edit Bug 17602 RecordedBooks integration to Koha - OPAC Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67236&action=edit Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66342|0 |1 is obsolete| | --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67238&action=edit Bug 17602: RecordedBooks Integration to Koha This patch introduces the required sysprefs and Koha::ExternalContent::RecordedBooks Koha::ExternalContent::RecordedBooks - a wrapper around WebService::ILS::RecordedBooks::PartnerPatron RecordedBooks* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_RecordedBooks.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I tested this patchset and have some comments. I used the credentials ByWater provided, with a logged-in user with Nick's email address set as primary (which is recognized as valid for the RecordedBooks credentials).

From the functional perspective, everything works as expected:

* Searches * Checkout * Checkin * Holds I would only try to make the UI tell the users it is working on something and prevent them from (re)clicking other RecordedBooks buttons (spinning symbol or similar). Not worth failing the patchset because of it, but definitely a needed followup. Regarding the whole patchset, I'd say tests coverage is not good enough. And having the tests require valid credentials for the proprietary external system seems too much. There are two options IMHO: - If the provider does have a sandbox/testbed infrastructure, use it - If it doesn't, keep the tests (which skip if credentials are missing) but add new db-independent tests with mocked behaviour for WebService::ILS. Auth_with_ldap.t can be a good source of examples for completely mocking the tests. I'm looking forward to help having this in 17.11, so don't hesitate to contact me for quick feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Integrate support for |Integrate support for |ONeclickDigital/Recorded |OneClickdigital/Recorded |Books API |Books API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #42 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 67859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67859&action=edit Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #44 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #41)

(In reply to Tomás Cohen Arazi from comment #39)

...

Regarding the whole patchset, I'd say tests coverage is not good enough. And having the tests require valid credentials for the proprietary external system seems too much. There are two options IMHO:

- If the provider does have a sandbox/testbed infrastructure, use it - If it doesn't, keep the tests (which skip if credentials are missing) but add new db-independent tests with mocked behaviour for WebService::ILS. Auth_with_ldap.t can be a good source of examples for completely mocking the tests.

Chris, Srdjan, any ideas how we could improve that? Can someone share the test credentials with me?

We have no contractual relationship, or any clients who use it. It is probably best to talk to Bywater or someone who have clients that might have a test account. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick note: use String.format() when needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #47)

(In reply to Jonathan Druart from comment #46)

...

Quick note: use String.format() when needed.

Money or somewhere else?

Hum? Money? I am talking about that kind of generated strings: $( '#recordedbooks-status' ).html( '<strong>' + _("Found") + ' ' + data.total + ' ' + _("results in the library's RecordedBooks collection.") + '</strong>' ); should be _("Found %s results in the library's RecordedBooks collection.").format(data.total) But it was a not for myself. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67860|0 |1 is obsolete| | --- Comment #50 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Comment on attachment 67860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67860 t/Koha_ExternalContent_OverDrive.t correction Obsoleted by 18851 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67237|0 |1 is obsolete| | Attachment #67238|0 |1 is obsolete| | Attachment #67240|0 |1 is obsolete| | Attachment #67859|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69019&action=edit Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69021&action=edit Bug 17602: OPAC integration of RecordedBooks Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69023&action=edit Bug 17602: Update opac.css -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69025&action=edit Bug 17602: Handle '60+' if there are more than 60 results The service returns "60+" if there are more than 60 results. Without this patch the "Found %s results in RecordedBooks collection" line is removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69027&action=edit Bug 17602: Fix few minor QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #63 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #61)

Some additional remarks: 1. At some point I got the following error: {"error":"Checkout item already exists"}Status: 200 OK

I have to let Nick decide on that one

2. Strings from .js files are not translatable, `git grep MSG_` to know how to make them translatable.

Done. Please let me know if it's not what you had in mind.

3. I see code related to pagination, but I do not see the previous/next buttons. I only see the OPACnumSearchResults first results.

Yes, at some stage the idea was to integrate all external searches into the main results page, so I stopped short of implementing paging - will be thrown away. Is it acceptable to leave as is?

And a question: Koha/ExternalContent/RecordedBooks.pm 76 user_agent_params => { agent => $class->agent_string } Where is this used?

It is a param for WebService::ILS. Cannot remember any more, possibly was a requirement for a provider that even did not get implemented. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #65 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #64)

I am not sure to understand what you did, I already fixed the some translations (patch "Bug 17602: Ease translation") from .tt, you needed to fix the strings in .js files (.inc and .tt were ok)

Right. Ok, before I do that. how do we handle messages that are the same in both OPAC and intranet? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69101|0 |1 is obsolete| | --- Comment #67 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 69357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69357&action=edit Bug 17602: Translations rework -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #69 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 69359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69359&action=edit Bug 17602: Removed unused param to RecordedBooks API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #71 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #64)

(In reply to Srdjan Jankovic from comment #63)

...

(In reply to Jonathan Druart from comment #61)

...

Some additional remarks: 1. At some point I got the following error: {"error":"Checkout item already exists"}Status: 200 OK

I have to let Nick decide on that one

Nick?

I was not able to recreate the error, a spinner would be nice here to indicate action is being performed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #73 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73709&action=edit Bug 17602: RecordedBooks Integration to Koha This patch introduces the required sysprefs and Koha::ExternalContent::RecordedBooks Koha::ExternalContent::RecordedBooks - a wrapper around WebService::ILS::RecordedBooks::PartnerPatron RecordedBooks* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_RecordedBooks.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #75 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73711&action=edit Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #77 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73713&action=edit Bug 17602: Handle '60+' if there are more than 60 results The service returns "60+" if there are more than 60 results. Without this patch the "Found %s results in RecordedBooks collection" line is removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73715&action=edit Bug 17602: Fix few minor QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73717&action=edit Bug 17602: fix RecordedBooks results pagination -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #83 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73719&action=edit Bug 17602: (follow-up) Adjust js paths to use version add spinner -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Maybe add a ref to OneClickdigital in the pref? "No system preferences matched your search for: OneClickdigital" (not blocking) 2. Found 241+ results in the library's RecordedBooks collection "+" ? 3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif must be using [% theme %]/[% interface %] 4. In the checkout list there is a link .epub (below "downloads"), but it downloads a .acsm file (??) Is it expected? 5. expires.toLocaleString() does not work what you are expecting, the date is always displayed in the same format (do not depend on dateformat) 6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org "Check out" and "Place hold" button are too close and not well styled (not blocking) 7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is still listed (not blocking) 8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d click on an image, https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your connection is not secure", awesome... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76181&action=edit Bug 17602: RecordedBooks Integration to Koha This patch introduces the required sysprefs and Koha::ExternalContent::RecordedBooks Koha::ExternalContent::RecordedBooks - a wrapper around WebService::ILS::RecordedBooks::PartnerPatron RecordedBooks* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_RecordedBooks.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #89 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76183&action=edit Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76185&action=edit Bug 17602: Handle '60+' if there are more than 60 results The service returns "60+" if there are more than 60 results. Without this patch the "Found %s results in RecordedBooks collection" line is removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76187&action=edit Bug 17602: Fix few minor QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76189&action=edit Bug 17602: fix RecordedBooks results pagination -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #97 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76191&action=edit Bug 17602: (follow-up) Adjust js paths to use version add spinner Also included recompiled version of opac.css that we forgot. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #99 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76193&action=edit Bug 17602: Use Asset TT plugin and fix indentation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76180|0 |1 is obsolete| | Attachment #76181|0 |1 is obsolete| | Attachment #76182|0 |1 is obsolete| | Attachment #76183|0 |1 is obsolete| | Attachment #76184|0 |1 is obsolete| | Attachment #76185|0 |1 is obsolete| | Attachment #76186|0 |1 is obsolete| | Attachment #76187|0 |1 is obsolete| | Attachment #76188|0 |1 is obsolete| | Attachment #76189|0 |1 is obsolete| | Attachment #76190|0 |1 is obsolete| | Attachment #76191|0 |1 is obsolete| | Attachment #76192|0 |1 is obsolete| | Attachment #76193|0 |1 is obsolete| | --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78602&action=edit Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #103 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78604&action=edit Bug 17602: OPAC integration of RecordedBooks Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78606&action=edit Bug 17602: Ease translation Use String.format() to make translation easier -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #107 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78608&action=edit Bug 17602: Adapt test plan to make the tests pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78610&action=edit Bug 17602: Translations rework -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78612&action=edit Bug 17602: Removed unused param to RecordedBooks API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78614&action=edit Bug 17602: Use Asset TT plugin and fix indentation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #115 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #85)

1. Maybe add a ref to OneClickdigital in the pref? "No system preferences matched your search for: OneClickdigital" (not blocking)

They are changing the name over to RecordedBooks, I think we should stick with this

2. Found 241+ results in the library's RecordedBooks collection "+" ?

This is a function of the values returned from the API, unfortunate but not in our control

3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif must be using [% theme %]/[% interface %]

This stil needs to be fixed, these lines are in the js file so don't have template variables

4. In the checkout list there is a link .epub (below "downloads"), but it downloads a .acsm file (??) Is it expected?

Yes, due to DRM you must get your epub via the adobe app which uses acsm

5. expires.toLocaleString() does not work what you are expecting, the date is always displayed in the same format (do not depend on dateformat)

This is what exists in the code for overdrive currently I believe - fix on a future bug?

6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org "Check out" and "Place hold" button are too close and not well styled (not blocking)

I will ask Owen for an eye

7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is still listed (not blocking)

Let's leave as improvement

8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d click on an image, https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your connection is not secure", awesome...

This is a configuratio issue - testing link used *.oneclickdigital.com - should now use *.rbdigital.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78602|0 |1 is obsolete| | Attachment #78603|0 |1 is obsolete| | Attachment #78604|0 |1 is obsolete| | Attachment #78605|0 |1 is obsolete| | Attachment #78606|0 |1 is obsolete| | Attachment #78607|0 |1 is obsolete| | Attachment #78608|0 |1 is obsolete| | Attachment #78609|0 |1 is obsolete| | Attachment #78610|0 |1 is obsolete| | Attachment #78611|0 |1 is obsolete| | Attachment #78612|0 |1 is obsolete| | Attachment #78613|0 |1 is obsolete| | Attachment #78614|0 |1 is obsolete| | Attachment #78615|0 |1 is obsolete| | Attachment #79247|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79668&action=edit Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79670&action=edit Bug 17602: OPAC integration of RecordedBooks Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79672&action=edit Bug 17602: Ease translation Use String.format() to make translation easier Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79674&action=edit Bug 17602: Adapt test plan to make the tests pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79676&action=edit Bug 17602: Translations rework Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79678&action=edit Bug 17602: Removed unused param to RecordedBooks API Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79680&action=edit Bug 17602: Use Asset TT plugin and fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #131 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79682&action=edit Bug 17602: Move spinner location to include file Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature integrates release notes| |RecordedBooks functionality | |into the catalog, following | |the model of OverDrive. | | | |Searches on the opac will | |return a link to results in | |the RecordedBooks catalog | |if they are found. From | |that results pagea user | |that is signed in and has a | |valid email matching a | |RecordedBooks account will | |be able to checkout the | |books directly from the | |results, and download them | |via their account page on | |the opac. Users will also | |be able to place holds on | |unavailable items. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79752&action=edit Bug 17602: Add missing html filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #134 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #133)

Created attachment 79752 [details] [review] Bug 17602: Add missing html filters

Followup pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21536 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 [Bug 21567] WebService:ILS related tests fail during package build -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #137 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- It is a huge pain, you have to have their test account. Which includes a password, and I'm not sure how is that dealt with in automated tests scenarios. The test is more or less a repeat of what is done in WebService::ILS itself, just through Koha. The main reason why I made WebService::ILS outside Koha is to cheat a bit - I could tests the whole structure locally and relieve that pain to some extent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 [Bug 33697] Remove RecordedBooks (rbdigital) integration -- You are receiving this mail because: You are watching all bug changes.