http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10799|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11088&action=edit Bug 8431 - Increase the borrower attribute field size from 64 characters to 255 Some libraries would like to store more verbose data in a borrower attribute field. This commit increases the maximum length of a borrower attribute from 64 characters to 255 characters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Tested * Upgrade to 3.09.00.XXX done (Increase the maximum size of a borrower attribute value) Checked the db borrower_attributes | CREATE TABLE `borrower_attributes` ( `borrowernumber` int(11) NOT NULL, `code` varchar(10) NOT NULL, `attribute` varchar(255) DEFAULT NULL, `password` varchar(64) DEFAULT NULL, KEY `borrowernumber` (`borrowernumber`), KEY `code_attribute` (`code`,`attribute`), CONSTRAINT `borrower_attributes_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_attributes_ibfk_2` FOREIGN KEY (`code`) REFERENCES `borrower_attribute_types` (`code`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The patch modifies the DB structure but template must be modified too. At least member/memberentrygen.tt: <input id="patron_attr_1" type="text" name="patron_attr_1" value="" maxlength="64"> I didn't verify if others occurrences exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11114&action=edit Bug 8431 - Followup - Switch from text input to textarea Switch the text input to a textarea will make editing larger borrower attritube values much easier. Since modern browsers allow for dynamic resizing of textareas, we can keep it small by default and let the library resize it if neccessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I know this is minor, but a textarea needs both a "rows" attribute and a "cols" attribute in order to be valid. Our validity score may not be 100% but let's not introduce new issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11113|0 |1 is obsolete| | Attachment #11150|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11166&action=edit [SIGNED-OFF] Bug 8431 - Followup - Switch from text input to textarea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11167&action=edit Bug 8431 - Follow-up - Correct and consolidate JavaScript for clearing rows This follow-up consolidates the JavaScript for clearing the contents of a row of patron attributes while expanding it to include all inputs, selects, and textareas within that row. Previously password-type fields would be excluded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11167|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11169&action=edit Bug 8431 [SIGNED-OFF][FOLLOW-UP] Increase the borrower attribute field size from 64 characters to 255 This follow-up consolidates the JavaScript for clearing the contents of a row of patron attributes while expanding it to include all inputs, selects, and textareas within that row. Previously password-type fields would be excluded. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #14 from Ian Walls <koha.sekjal@gmail.com> --- 1st patch: just increases size of field in new and upgraded installs. Passed QA 2nd patch: changes input to text area to accomodate new size. Passed QA 3rd patch: jQuery consolidation of input clearing. Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12106&action=edit Bug 8431 - Followup - Use TT filter html_line_break on extended attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #16)

Created attachment 12106 [details] Bug 8431 - Followup - Use TT filter html_line_break on extended attributes.

Thx for the follow-up, but you missed that is is also neede in moremember.tt and opac-userupdate.pl I've updated the 2 templates in a follow-up Patch pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.