[Bug 25635] New: overdue_notices.pl dies if no overdue rules are defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Bug ID: 25635 Summary: overdue_notices.pl dies if no overdue rules are defined Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org overdue_notices.pl dies if no overdue rules are defined, but there are many cases where you might not want any overdue rules to be defined. (If you're running overdue_notices.pl within koha-foreach, koha-foreach will now die on the first instance it encounters that has no overdue rules defined.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25634 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, even with bug 25634 fixed I think we should replace the die with a warn+exit 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is that a regression? We certainly have libraries without rules and multiple instances on servers... Having no rules should not be seen as a problem or error, it's just configuration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17532 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The behaviour of the script has not been modified, but the consequence on koha-foreach comes from a change in koha-shell (bug 17532) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 [Bug 17532] koha-shell -c does not propagate the error code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That explains why we haven't run into this yet on production systems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #1)
Yes, even with bug 25634 fixed I think we should replace the die with a warn+exit 0
That's my thinking too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will this be fixed by bug 17532 or do we need to adjust the overdues script as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #6)
Will this be fixed by bug 17532 or do we need to adjust the overdues script as well?
Bug 17532 actually makes this a problem as noted in Bug 25634. Bug 25634 resolves the main problem that Bug 17532 introduced, but the overdues script should be adjusted anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38307 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from David Cook <dcook@prosentient.com.au> --- I think that this might arguably be a duplicate of bug 38307 The original problem was resolved by bug 25634 and bug 38307 controls the verbosity of the warning so I think that's all good. I don't think I've had any issues in prod for several years so happy to close this one *** This bug has been marked as a duplicate of bug 38307 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org