[Bug 33716] New: ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Bug ID: 33716 Summary: ILL - Allow for a disclaimer stage per request type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: andrew.auld@ptfs-europe.com, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Created attachment 151027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151027&action=edit Workflow diagram This new feature should allow the specification of a new custom HTML message alongside a custom authorised values category to be presented to the user after the ILL request has been submitted, on both OPAC and Staff. This should also allow for different specifications for each request type, and a fallback disclaimer if the type of the new ILL request being created does not exist in the new system preference. Once the disclaimer is submitted, the selected value from authorised values category as well as a timestamp should be saved in the database. To implement this, a refactor of the current ILLCheckAvailability system preference is required to make sure this new feature works in harmony, as it's also an extra step the user must take after it has submitted the create request form, but before the request has been saved in the database. Please check the attached diagram. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151031&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151032&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151033&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151034&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151035&action=edit Bug 33716: Tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Apply patches, on ktd, preparation: - Run reset_all - Run sh start-ill-dev.sh (copy from https://github.com/ammopt/koha-ill-dev/blob/master/start-ill-dev.sh) Test plan: 1 Go to system preferences, check the new YAML preference ILLModuleDisclaimerByType 2 Copy the bold example YAML text into the system preference input box 3 Go to ILL Requests click "New ILL request" (Pick FreeForm if you have more than one backend installed) 4 Pick type "Journal article", enter "42" in cardnumber and a random library, create. Notice the request is created normally. 5 Go back to the system preferences, remove the "bypass: 1" line, save. 6 Repeat 3 and 4 7 Verify that a Type Disclaimer stage now exists. Verify that the text being presented is the one specified for "article" in the system preference. Submit it. 8 Verify that that the disclaimer value and disclaimer date have been saved as illrequestattributes for that ILL request. 9 Repeat 3 and 4 but with a different type 10 Verify that the text being presented is the one defined in "all" in the system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151031|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151146&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151032|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151147&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151033|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151148&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151034|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151149&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151035|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151150&action=edit Bug 33716: Tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151146|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151388&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151147|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151389&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151148|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151390&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151149|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151391&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151150|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151392&action=edit Bug 33716: Tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151393&action=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151394&action=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151401&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151401|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 151402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151402&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151388|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151403&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151389|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151404&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151390|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151405&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151391|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151406&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151392|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151407&action=edit Bug 33716: Tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151393|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151408&action=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151394|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151409&action=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151402|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151410&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151410|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151411&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Minor issues: - Missing DB update - we should add the pref with no value - Koha/Illrequest/Workflow.pm - some copy/paste issues (TypeDisclaimer) - Type_disclaimer_date and Type_disclaimer_value on 'Request details' display over the values, needs styling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152809&action=edit Bug 33716: (QA follow-up) Add atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152810&action=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152811&action=edit Bug 33716: (QA follow-up) Fix styling for Type_disclaimer_date and Type_disclaimer_value on 'Request details' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151403|0 |1 is obsolete| | Attachment #151404|0 |1 is obsolete| | Attachment #151405|0 |1 is obsolete| | Attachment #151406|0 |1 is obsolete| | Attachment #151407|0 |1 is obsolete| | Attachment #151408|0 |1 is obsolete| | Attachment #151409|0 |1 is obsolete| | Attachment #151411|0 |1 is obsolete| | Attachment #152809|0 |1 is obsolete| | Attachment #152810|0 |1 is obsolete| | Attachment #152811|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152813&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152814&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152815&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152816&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152817&action=edit Bug 33716: Tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152818&action=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152819&action=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152820&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152821&action=edit Bug 33716: (QA follow-up) Add atomic update file Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152822&action=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152823&action=edit Bug 33716: (QA follow-up) Fix styling for Type_disclaimer_date and Type_disclaimer_value on 'Request details' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152822|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152826&action=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm and TypeDisclaimer.pm Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I squashed more minor comment updates to the copy/paste fixes patch and kept your signature in it Nick. Thanks for looking at this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #47)
I squashed more minor comment updates to the copy/paste fixes patch and kept your signature in it Nick. Thanks for looking at this!
Yeah, nice catch ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Nick :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154305&action=edit Bug 33716: (QA follow-up) Update z39.50 availability search in 'Request from partners' screen Test plan: - Enable ILLCheckAvailability; - Enable ILLModule and install FreeForm - Update partner_code in koha-conf.xml to match the patron category being used ('IL' if on k-t-d) - Install and configure z39.50 availability plugin, link it to the patron ID ('16' if on k-t-d) - Add a valid e-mail address to the patron of 'IL' category - Create a new ILL request and go to 'Manage request' screen - Click 'Place request with partners' notice the label 'Partners available for searching: none' - Apply patch and refresh, notice a 'Search selected partners' button now shows up after you select the partner from the list This is a fix for a regression caused by the rest of the code in this bug. I'm submitting this here since this has not yet been pushed and the fix is quite self-explanatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154454&action=edit Bug 33716: (QA follow-up) Fix xt/yaml_valid.t Test plan: Run prove -vv xt/yaml_valid.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #52 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154714&action=edit Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid Issue that this patch fixes: 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Copy the example YAML text into the system preference input box 3) Create a new FreeForm request and enter a duff borrowernumber e.g. '11111111111111' 4) Click 'Create'. Submit the type disclaimer stage. 5) Notice there's an error 6) Apply this patch. 7) Repeat steps 3 and 4. Verify that the correct 'The borrower details you entered are invalid' error message is displayed instead of the error in 5). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #54 from Fridolin Somers <fridolin.somers@biblibre.com> --- New feature not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |This introduces a new YAML submission| |system preference: | |ILLModuleDisclaimerByType Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation|This introduces a new YAML | submission|system preference: | |ILLModuleDisclaimerByType | Text to go in the| |This introduces a new YAML release notes| |system preference: | |ILLModuleDisclaimerByType. | |This new system preference | |allows for different text | |and dropdown options to be | |displayed to user | |(Staff+OPAC) depending on | |the request type | |introduced. | |The new type | |disclaimer screen is | |presented after the create | |request form has been | |submitted, but before the | |request is saved. Thus only | |allowing for a request to | |be placed if the user | |accepts the disclaimer. | |The | |accepted disclaimer option | |is saved in the database to | |allow it to be viewed | |afterwards, as well as the | |timestamp it was accepted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This introduces a new YAML |**Sponsored by** *NHS release notes|system preference: |England* |ILLModuleDisclaimerByType. | |This new system preference |This introduces a |allows for different text |new YAML system preference: |and dropdown options to be |ILLModuleDisclaimerByType. |displayed to user |This new system preference |(Staff+OPAC) depending on |allows for different text |the request type |and dropdown options to be |introduced. |displayed to user |The new type |(Staff+OPAC) depending on |disclaimer screen is |the request type |presented after the create |introduced. |request form has been |The new type |submitted, but before the |disclaimer screen is |request is saved. Thus only |presented after the create |allowing for a request to |request form has been |be placed if the user |submitted, but before the |accepts the disclaimer. |request is saved. Thus only |The |allowing for a request to |accepted disclaimer option |be placed if the user |is saved in the database to |accepts the disclaimer. |allow it to be viewed |The |afterwards, as well as the |accepted disclaimer option |timestamp it was accepted. |is saved in the database to | |allow it to be viewed | |afterwards, as well as the | |timestamp it was accepted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *NHS |This introduces a new YAML release notes|England* |system preference | |`ILLModuleDisclaimerByType` |This introduces a |allowing for different text |new YAML system preference: |and dropdown options to be |ILLModuleDisclaimerByType. |displayed to user |This new system preference |(Staff+OPAC) depending on |allows for different text |the request type |and dropdown options to be |introduced. |displayed to user | |(Staff+OPAC) depending on |The new type |the request type |disclaimer screen is |introduced. |presented after the create |The new type |request form has been |disclaimer screen is |submitted, but before the |presented after the create |request is saved. Thus, |request form has been |only allowing for a request |submitted, but before the |to be placed if the user |request is saved. Thus only |accepts the disclaimer. |allowing for a request to | |be placed if the user |The accepted disclaimer |accepts the disclaimer. |option is saved in the |The |database to allow it to be |accepted disclaimer option |viewed afterwards, as well |is saved in the database to |as the timestamp it was |allow it to be viewed |accepted. |afterwards, as well as the | |timestamp it was accepted. |**Sponsored by** | |*NHS England* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/907 --- Comment #55 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I don't use the ILL module, so I hope I described this correctly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #56 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Caroline Cyr La Rose from comment #55)
I don't use the ILL module, so I hope I described this correctly...
I've taken a quick look. I think it describes it accurately and clearly. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #57 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Pedro Amorim from comment #56)
(In reply to Caroline Cyr La Rose from comment #55)
I don't use the ILL module, so I hope I described this correctly...
I've taken a quick look. I think it describes it accurately and clearly. Thank you!
Thanks for checking Pedro! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org