[Bug 14590] New: Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Bug ID: 14590 Summary: Checkboxes should be disabled without valid contact information in messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: larit@student.uef.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently, in Patron message preferences, it is possible to set message transport type without valid contact information (e.g. send sms even if patron does not have a phone number set). This is very problematic for us since we have several Borrowers with misconfigured messaging preferences, and that causes issues, like Borrowers not knowing they have Items waiting for pickup. This makes customers angry and our librarians sad, not to mention the technical staff. Reasons for this are myriad but one big challenge is misconfigured messaging preferences, both in OPAC and the staff client. I have listed messaging preferences that would need to require valid contact information: #1 SMS (this requires valid SMSnumber) #2 Phone (this requires valid phone) #3 Email (this requires valid email) Validations will be done both client-side and server-side. I am working on the following plan: Server-side validation - In C4::Form::MessagingPreferences::handle_form_action(), check for each parameter (SMSnumber, phone, email) to see if they are provided. - If the parameter is provided, allow message_transport_types to contain said transport method for this message. - If the parameter is not provided, remove the said transport method for this message from message_transport_types. Client-side validation - Has to be done in both OPAC and staff client. - With JavaScript, check the contents of each contact field (SMSnumber, phone, email). - If the contact field is invalid or empty, remove all checks from messaging preferences checkboxes for this transport type. Also disable these checkboxes. - Once the contact field becomes valid on input event, enable checkboxes for this transport type and restore any previously stored state (e.g. we just want to change phone number without setting all messaging preferences again). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |larit@student.uef.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5685 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 [Bug 5685] Validation of email address field -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14620 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41496&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything) 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #2 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41497&action=edit Bug 14590 - PageObject tests for misconfigured messaging preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14621 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 [Bug 14621] Messaging preferences table needs to be sorted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41496|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41526&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything) 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41526|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41528&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41528|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41700&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41700|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41701&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41701|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41884&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41884|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <larit@student.uef.fi> --- Created attachment 41991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41991&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Lari Taskula <larit@student.uef.fi> --- This patch makes both client and server side validations, both in OPAC and Staff client. Depends on Bug 14620. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41991|0 |1 is obsolete| | --- Comment #10 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42457&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 42464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42464&action=edit [Signed-off] Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Followed test plan (comment #9), works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 14620 which is blocked by bug 7174. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42464|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <larit@student.uef.fi> --- Created attachment 44704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44704&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. Fixing category messaging preferences broken by previous patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org