[Bug 30629] New: <span> in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Bug ID: 30629 Summary: <span> in title of patron card creator template needs to be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org <title> elements are not allowed to have <span> elements, they show as such in the browser tab. There is a wrong span in the template for: /cgi-bin/koha/patroncards/manage.pl?card_element=template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 [Bug 29602] We must be nicer with translators -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe keep the span in PROCESS and remove them in <title> creation. I've tryed but could not use filters on a PROCESS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Bug 30629 depends on bug 29602, which changed state. Bug 29602 Summary: We must be nicer with translators https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It would be nice to have at least the *possibility* of using a construction like "[% t('Layouts') | html %]" as proposed in Bug 26932. This would prevent a lot of ugly cases like this were we add useless <span>s. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Bug 26932 looks like a typo, it's unrelated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Searching for <title> that processes a BLOCK with [% PROCESS %] shows that the following pages are affected: modules/admin/aqplan.tt block defined in budget_planning.inc patroncards/manage.tt block defined in same template labels/label-manage.tt block defined in same template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe we could have a TT filter that removes all HTML tags. Looks like it does not exist in current lib : http://template-toolkit.org/docs/manual/Filters.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 134989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134989&action=edit Bug 30629: fix <span> in title of some pages == Test plan == 1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 2. See that the page title in your browser window title is wrong because it contains <span> 3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batc... 4. See that the page title in your browser window title is wrong because it contains <span> 5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl 6. Administration => Budgets => Click on a budget => planning => plan by months 7. See that the page title in your browser window title is wrong because it contains <span> 8. Refresh the pages and see that the titles are correct 9. Sign off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134989|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 134990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134990&action=edit Bug 30629: fix <span> in title of some pages == Test plan == 1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 2. See that the page title in your browser window title is wrong because it contains <span> 3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batc... 4. See that the page title in your browser window title is wrong because it contains <span> 5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl 6. Administration => Budgets => Click on a budget => planning => plan by months 7. See that the page title in your browser window title is wrong because it contains <span> 8. Refresh the pages and see that the titles are correct 9. Sign off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Fridolin Somers from comment #5)
Maybe we could have a TT filter that removes all HTML tags.
Looks like it would be a workaround on top of the other workaround which is our use of <span> to guide the translation string extractor. t() works though. Testing note: translatability has been checked. And it's a string change so mind the string freeze. Because even if the strings are the same. They are moved from the staff .po to the messages .po and there is no existing occurrence of at least one of the strings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134990|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 135001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135001&action=edit Bug 30629: fix <span> in title of some pages == Test plan == 1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 2. See that the page title in your browser window title is wrong because it contains <span> 3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batc... 4. See that the page title in your browser window title is wrong because it contains <span> 5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl 6. Administration => Budgets => Click on a budget => planning => plan by months 7. See that the page title in your browser window title is wrong because it contains <span> 8. Refresh the pages and see that the titles are correct 9. Sign off :) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135001|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135096&action=edit Bug 30629: fix <span> in title of some pages == Test plan == 1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 2. See that the page title in your browser window title is wrong because it contains <span> 3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batc... 4. See that the page title in your browser window title is wrong because it contains <span> 5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl 6. Administration => Budgets => Click on a budget => planning => plan by months 7. See that the page title in your browser window title is wrong because it contains <span> 8. Refresh the pages and see that the titles are correct 9. Sign off :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- that one depends on 29602, not sure it is relevant for 21.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes <span> tags release notes| |incorrectly displaying in | |browser page titles for | |some pages in the staff | |interface (Tools > Patron | |card creator > Layouts; | |Tools > Label creator > | |Manage > Label batches; | |Administration > Budgets | |administration > select a | |budget > Plan by ...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31069 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org