[Bug 23405] New: Circulation autocomplete for patron lookup broken if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Bug ID: 23405 Summary: Circulation autocomplete for patron lookup broken if cardnumber is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If CircAutocompl is enabled, the staff client's "check out" search form in the header has a patron search autocomplete feature. Selecting a result should take you to the patron's checkout screen. Because this uses card number, it doesn't work with patrons who have no card number. It should use borrowernumber instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91894&action=edit Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91894|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91939&action=edit Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Ian Walls <ian@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91939|0 |1 is obsolete| | --- Comment #3 from Ian Walls <ian@bywatersolutions.com> --- Created attachment 91940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91940&action=edit Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Ian Walls <ian@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91940|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92041&action=edit Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty This patch modifies the JavaScript behind the patron search results autocomplete widget which is displayed when typing in the search header's "Check out" tab. The script is modified to use the patron's borrowernumber instead of cardnumber when redirecting to the checkout page. Instead of copying the patron's card number into the search form and triggering a submit, the autocomplete output uses direct links to each result. To better handle patrons with no card number, the output is modified to show card number with parentheses only if card number is present. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Patrons with a card number should be listed in the format: Surname, First name (Card number) Address. - Patrons without a card number should be listed as: Surname, First name Address. - Clicking on either kind of result should link you the checkout screen for that patron. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Ian Walls <ian@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 [Bug 23518] Problem with borrower search autocomplete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org