[Bug 15798] New: C4::Koha::displayServers is no longer in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Bug ID: 15798 Summary: C4::Koha::displayServers is no longer in use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47896&action=edit Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I agree. mtompset@debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 59fc325 Bug 15684: Fix encoding issues with quote upload mtompset@debian:~/kohaclone$ git grep -n displayServers C4/Koha.pm:53: &displayServers C4/Koha.pm:1013:=head2 displayServers C4/Koha.pm:1015: my $servers = displayServers(); C4/Koha.pm:1016: my $servers = displayServers( $position ); C4/Koha.pm:1017: my $servers = displayServers( $position, $type ); C4/Koha.pm:1019:displayServers returns a listref of hashrefs, each containing C4/Koha.pm:1037:sub displayServers { mtompset@debian:~/kohaclone$ git bz apply 15798 Bug 15798 - C4::Koha::displayServers is no longer in use 47896 - Bug 15798: Remove C4::Koha::displayServers Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15798: Remove C4::Koha::displayServers mtompset@debian:~/kohaclone$ git grep -n displayServers mtompset@debian:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47896|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47900&action=edit [SIGNED-OFF] Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. NOTE: See my testing output in comment #2. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47900|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 47952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47952&action=edit Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Jonathan! Should be in the Koha 3.24 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org