[Bug 29057] New: Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Bug ID: 29057 Summary: Use font awesome icons on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a few images we use here, they could be replaced with font-awesome icons It looks like the 'top'/'bottom' icons require a pro license, but the filled circle arrows seem a close equivalent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125049&action=edit Bug 29057: Use font awesome icons on request.pl To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29057: Use font awesome icons on request.pl error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125049|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125061&action=edit Bug 29057: Use font awesome icons on request.pl To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Applying: Bug 29057: Use font awesome icons on request.pl Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129413&action=edit Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- I like Owen's patch. The only thing I would say is that the use of the using the 'fa-rotate-90 fa-fast-foward' icon in the 'Toggle set to lowest priority' <th> column looks awkward. Is it nessesary to have it in the <th>? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- We should take screen shots to present the 2 solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- And check if we can remove files img/go-xxx.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from shi-yao.wang@inLibro.com --- Patch doesn't apply. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131650&action=edit before pic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131651&action=edit nick patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131652&action=edit owen patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Added pics of before and after with both patches Obsoleting mine in favor of Owen's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm testing. Looks good but I see some issues : When hovering button "Move hold to top/bottom" we see that horizontal line color does not change. This is because it is not part of the icon, it is a CSS border. Looks dangerous to me. Why is icon for "Toggle lower priority" different from "Move hold to bottom" ? I propose we use "angle" FA icons : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down Single arrow for "Move hold up/down" and double arrow for "Move hold to top/bottom". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131877&action=edit Bug 29057: (follow-up) Make arrow border hover state the correct color -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131878&action=edit Screenshot of interface using angle icons (In reply to Fridolin Somers from comment #14)
Why is icon for "Toggle lower priority" different from "Move hold to bottom" ?
I think it should be different because it performs a different function. I think the current version with the arrow images is confusing because they're not different enough. The angle icons are not my top choice, but it is nice that there could be three variations on the same one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I like the first version from Owen the best so far, but we do have an issue with the fifth icon (and kinda always had). I think on another bug we had discussed using something like a 'pin' to indicate that it pins the hold to the bottom. Could we do some combination of 'move to bottom' with a red pin in it or so? https://fontawesome.com/v3/icon/pushpin I think we need something similar but yet different (which makes it quite hard). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> ---
I think it should be different because it performs a different function. Ah OK I was not aware of that :)
Tooltip text is a good first help. But a good icon would be nice. Maybe use "angle" icons to move up/down/top/bottom : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down And a "angle double down" with underline has 5th icon (toggle lowest priority). Meaning go to bottom and stick there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |aleisha@catalyst.net.nz --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- It sounds like this is not yet ready for testing and awaiting a new patch? Adjusting bug status - feel free to change back if I'm wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- If anyone wants to leave their vote on which of the options screenshotted in the attachments looks best to them maybe this could move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #21 from David Nind <david@davidnind.com> --- I like the one called "owen patch" the best, but they all nice improvements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129413|0 |1 is obsolete| | Attachment #131877|0 |1 is obsolete| | --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134896&action=edit Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- the possibilities are endless https://snipboard.io/UCbkzr.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134896|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 134942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134942&action=edit Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the arrows used on the | |holds page for a record to | |change the hold priority. | |Instead of using images for | |the arrows, Font Awesome | |icons are now used. | | | |In | |addition, you can now | |override the icons using | |any Font Awesome icons in | |the IntranetUserCSS system | |preference. For an example, | |see | |https://gitlab.com/-/snippe | |ts/2319364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #25 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #23)
the possibilities are endless https://snipboard.io/UCbkzr.jpg
Nice! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- I agree with David choice, lets go this that 👊 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134942|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134966&action=edit Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be bacckported to 22.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 4230 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org