[Bug 21225] New: Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Bug ID: 21225 Summary: Add Syndetics enhanced content to staff client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bibliwho@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Syndetics enhanced content is currently only available in the OPAC. It would be helpful if content were also available in the staff client (as it is for NoveList, for example). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Jeremy Evans <jeremy.evans@phe.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@phe.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 116911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116911&action=edit Bug 21225: Add Syndetics cover images to staff client. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Andreas, Sadly, this patch no longer applies cleanly to master. Is there any chance for a rebase? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- A test plan would also be great. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- We’d love for our Syndetics content to display in staff, especially the cover images for DVDs, since Amazon does not display those. Our staff would be better able to help our patrons if they were able to see these cover images. It would also save them time from having to switch to the OPAC to see a DVD cover image. Is it possible to rebase the patch and provide a test plan so we could get this one moving? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116911|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123581&action=edit Bug 21225: Add Syndetics cover images to staff client. This patch adds support for Syndetics Cover Images to the staff client To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Cover images display fine in the results pages. However, sometimes they display on the detail pages and sometimes they don’t. It appears that even though the ISBN is present in the 020 tag, the images won’t display on detail pages unless they also have an OCLC # in the O35 tag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to Failed QA because of comment#6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #8 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Just checking on the status of this one. We would love to be able to see Syndetics covers in the staff client, especially for DVDs, and other materials that Amazon doesn't have covers for such as Playaways. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123581|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130638&action=edit Bug 21225: Add Syndetics cover images to staff client. To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130640&action=edit Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I tested again and it is working better. Here's the latest: • Bib with ISBN only in the 020 - cover images display on results and details • Bib with UPC only in the 024_1 - cover images display on results and details • Bib with and 020 or 024_1 along with the 035 - cover images display on results and details • Bib with OCLC # only in the 035 - cover images do not display - I tested this in my staff interface and it was the same so I don't think they are supposed to display if the bib only has an OCLC# • Clicking on the Syndetics cover image from the details page - brings up a page with just a spinning loader icon instead of displaying an enlarged image as it does with an Amazon cover • Two cover image services enabled - everything worked as outlined above with both Amazon and Syndetics enabled • Cover images that display in the staff interface also display in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130689&action=edit Bug 21225: (follow-up) Account for Syndetics lightbox To test: -Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. -Turn on some other cover image services and make sure you can toggle through each of them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Syndetics enhanced |Add Syndetics cover images |content to staff client |to staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #14 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Clicking on the Syndetics image in the detail page now displays the image in the lightbox. However, it is the same size image used on the detail page. When doing this with an Amazon image the detail page shows a smaller image but in the lightbox it is enlarged so you can see more detail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130689|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130690&action=edit Bug 21225: (follow-up) Account for Syndetics lightbox To test: -Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. -Turn on some other cover image services and make sure you can toggle through each of them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130638|0 |1 is obsolete| | --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 130696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130696&action=edit Bug 21225: Add Syndetics cover images to staff client. To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130640|0 |1 is obsolete| | --- Comment #17 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 130697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130697&action=edit Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130690|0 |1 is obsolete| | --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 130698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130698&action=edit Bug 21225: (follow-up) Account for Syndetics lightbox To test: -Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. -Turn on some other cover image services and make sure you can toggle through each of them. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Everything worked and looked great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please check the filter issues noted by the QA test tools? As I can't test with Syndetics, I don't want to mess with it: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters wrong_html_filter at line 243 ( <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/LC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" title="Syndetics cover image">) wrong_html_filter at line 243 ( <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/LC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" title="Syndetics cover image">) wrong_html_filter at line 243 ( <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/LC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" title="Syndetics cover image">) wrong_html_filter at line 243 ( <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/LC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" title="Syndetics cover image">) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132357&action=edit Bug 21225: (follow-up) correct filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130696|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132366&action=edit Bug 21225: Add Syndetics cover images to staff client. To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130697|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132367&action=edit Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130698|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132368&action=edit Bug 21225: (follow-up) Account for Syndetics lightbox To test: -Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. -Turn on some other cover image services and make sure you can toggle through each of them. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132357|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132369&action=edit Bug 21225: (follow-up) correct filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132370&action=edit Bug 21225: (QA follow-up) Update pref description of SyndeticsCoverImages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if it would make sense to have a separate preference, but I think we can leave that to the libraries using Syndetics :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 31111 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389 [Bug 32389] Syndetics links are built wrong on the staff results page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org