[Bug 41579] New: Tidy kohaTable block - suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Bug ID: 41579 Summary: Tidy kohaTable block - suggestions Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Blocks| |41324 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191161&action=edit Bug 41579: Tidy kohaTable - suggestion/suggestion.tt Patch from commit 271922c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191162&action=edit Bug 41579: suggestions - auto tidy Patch from commit 1276d44 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41546 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41546 [Bug 41546] Cannot unarchive suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41545 [Bug 41545] JS warning "redeclaration of let filters_options" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191161|0 |1 is obsolete| | Attachment #191162|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191565&action=edit Bug 41579: Tidy kohaTable - suggestion/suggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191566&action=edit Bug 41579: suggestions - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191565|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192739&action=edit Bug 41579: Tidy kohaTable - suggestion/suggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192740&action=edit Bug 41579: suggestions - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed conflict with bug 39721. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Bug 41579 depends on bug 41545, which changed state. Bug 41545 Summary: JS warning "redeclaration of let filters_options" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41545 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192739|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194810&action=edit Bug 41579: Tidy kohaTable - suggestion/suggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192740|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194811&action=edit Bug 41579: suggestions - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195450&action=edit Bug 41579: (follow-up) Tidy kohaTable - suggestion/suggestion.tt Patch from commit 1531be7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #11)
Created attachment 195450 [details] [review] Bug 41579: (follow-up) Tidy kohaTable - suggestion/suggestion.tt
Patch from commit 1531be7
Pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41579 Bug 41579 depends on bug 41546, which changed state. Bug 41546 Summary: Cannot unarchive suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41546 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org