[Bug 21662] New: Missing Developers from history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Bug ID: 21662 Summary: Missing Developers from history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org I've been doing some git digging (a lunchtime project inspired by bug 20720) and found that there's a fair number of contributors missing from the history tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20720 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81466&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81467&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81468&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The first patch tries to clean up leading and trailing whitespace from each tab-delimited column. Katrin pointed out this may be a problem for the website? The second patch makes the actual changes to the history.txt file.. there's a lot of noise in that patch as it's required to renumber commiters.. I've extracted the 'important' lines below for review: Missing Developers +1059703830 August 1 2003 Rachel Hamilton-Williams becomes the 29th committer to Koha developer +1252258885 September 6 2009 Jean-andré Santoni becomes the 99th committer to Koha developer +1254303027 September 30 2009 John Soros becomes the 100th committer to Koha developer +1296281924 January 29 2011 David Schuster becomes the 138th developer to have a patch pushed developer +1342191932 July 13 2012 Wajasu becomes the 195th developer to have a patch pushed developer +1359650663 January 31 2013 Ed Veal becomes the 209th developer to have a patch pushed developer +1390496638 January 23 2014 Jatara Barnes becomes the 253rd developer to have a patch pushed developer +1394549843 March 11 2014 Nicholas Van Oudtshoorn becomes the 255th developer to have a patch pushed developer +1421282617 January 15 2015 शंतनू becomes the 287th developer to have a patch pushed developer +1421588456 January 18 2015 Thomas Misilo becomes the 288th developer to have a patch pushed developer +1429539894 April 20 2015 Winona Salesky becomes the 292nd developer to have a patch pushed developer +1445522767 October 22 2015 Ahmed becomes the 304th developer to have a patch pushed developer +1461932425 April 29 2016 Bouzid Fergani becomes the 313th developer to have a patch pushed developer +1535127807 August 24 2018 Maryse Simard becomes the 381st developer to have a patch pushed developer Fixed Developers +1117720067 June 2 2005 Gavin McCullagh becomes the 36th committer to Koha developer (Change from Gavin ??) +1289527356 November 12 2010 Chris Hall becomes the 125th committer to have a patch accepted developer (moved from 136th) Removed Developers -1211068800 May 18 2008 Koha production??? becomes the 62nd committer to Koha developer (not exactly meaningful) -1479895944 November 23 2016 Petter Goksøyr Åsen becomes the 314th developer to have a patch pushed developer (was listed twice) -1519060391 February 19 2018 Pongtawat Chippimolchai becomes the 358th developer to have a patch pushed developer (was listed twice as pongtawat and Pongtawat Chippimolchai) Left as is, but questionable -1453075201 January 18 2016 Natasha ?? becomes the 295th developer to have a patch pushed developer (Any advances on ??) I've extracted this data from a mixture of git and the existing history.txt file. Git wise I used `git -c i18n.logOutputEncoding=UTF-8 log --pretty=format:"%ct, %an, %ae"` to grab every commit, ensuring utf8 encoding, with it's commite time (not the authored time, it made sense to order by when the patch was accepted rather than authored, the author name and author email. I'll post the script i wrote to help me disambgaute between names. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81469&action=edit get_developer.pl As promised.. here's the script I contrived to create the attached history.txt patch. I intend to work a lot of it into the release-tools (and remove all the hard-coded file paths etc) to allow for simpler maintenance of these files at release time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Anyone in the know, know how https://koha-community.org/about/history/ is generated? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You will want to update about.tt as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #6)
Anyone in the know, know how https://koha-community.org/about/history/ is generated?
Last update is from August 18, 2016, so I guess there is a script updating the content automatically. I guess Chris or Liz know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- That's right, that page is updated daily from Master. I've fixed the encoding - the database had been installed in latin1, it's now UTF8. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, thanks Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81466|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82367&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81467|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82368&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81468|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82369&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 [Bug 21626] Add 'current maintenance team' to the 'Koha team' page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82367|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87759&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82368|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87760&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82369|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87761&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87762&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #18 from Michal Denar <black23@gmail.com> --- Hi Martin and Liz, any test for this patch? On Abou tpage Is till see Natasha ?? or Andy??. Is it correct? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed, those two are early contributors I haven't yet been able to narrow down further.. It's in my to do list to try and see if Chris has any idea's on how I might be able to narrow them down further and give proper attribution to them. Test plan wise it's really a case of comparing side by side the results of these patches against an about page without them.. we should not be missing anyone from the original and have a few new additions on the patched version.. Also, the committer numbers have been re-ordered slightly where I've had to slip an extra missed contributor into the order. The other side of this is the get_developers.pl script. If you have a clone of the release_tools you can run this script using the dev_map file available within it and check the results match.. but I think that's perhaps out of scope for this particular bug.. my intention is to fold the functionality of that script into the release_tools so as part of the release process we're automatically maintaining this list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87759|0 |1 is obsolete| | Attachment #87760|0 |1 is obsolete| | Attachment #87761|0 |1 is obsolete| | Attachment #87762|0 |1 is obsolete| | --- Comment #20 from Michal Denar <black23@gmail.com> --- Created attachment 88098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88098&action=edit Bug 21662: Make history.txt whitespace consistent Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #21 from Michal Denar <black23@gmail.com> --- Created attachment 88099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88099&action=edit Bug 21662: Update history.txt Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #22 from Michal Denar <black23@gmail.com> --- Created attachment 88100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88100&action=edit Bug 21662: Add Contributors.yaml file Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #23 from Michal Denar <black23@gmail.com> --- Created attachment 88101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88101&action=edit Bug 21662: Use contributors.yaml for contributors list Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the signoff, it'll be nice to get this workflow running.. I love automating things like this as much as possible.. save us devs adding human error into the mix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing Developers from |Missing developers from |history |history CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am almost happy here, but for some things: This doesn't look as nice as it should - I think we need to translate the codes into something nice and translatable: documentation_team (17.11) maintainer (17.05 17.11) qa (3.16 3.18 3.20 3.22 3.24 16.05) qa_manager (16.11 18.05 18.11 19.05) It's also not quite right... (3.12 - 16.11 QA Manager, 16.11 Release Maintainer, 17.11 Documentation Team Member, 18.05 QA Manager) Feeling a little odd to point out :) I am suggesting this change too: -1252258885 September 6 2009 Jean-andré Santoni becomes the 99th committer to Koha developer +1252258885 September 6 2009 Jean-André Santoni becomes the 99th committer to Koha developer Failed for the first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88098|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88479&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88099|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88480&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88100|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88481&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88101|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88482&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think I've resolved all issue now.. back to NQA Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88485&action=edit After -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88486&action=edit Before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I wonder if Owen has any hints/tips regarding the slightly modified look of the 'Koha Development Team' section (I've attached before and after screenshots).. I've run aground at displaying the extra information given to us regarding team role breakdown for each contributor. Also.. there's still a couple of '???' contributors in there.. I'd love to get Chris's thoughts on those people. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some small stuff: - Bugwrangler => Bug wrangler - Maybe add punctuation between versions? - Some of the roles are still not quite right, but were before. Maybe this is not the latest version? :( - Some additional fix to smuggle into history.txt: Rachel Hamilton-Willams of Katipo sends access to the katipo cma to edit the new koha.org site => ... Katipo CMS ... I generally like the more structured display of information :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> --- Natasha was an Academy student who didn't want to use her last name. So can we make that just Natasha. (I do know, who it is but respect their wish for privacy) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #36 from Chris Cormack <chris@bigballofwax.co.nz> --- So Andy is kb2qzv Which leads to https://sourceforge.net/u/kb2qzv/wiki/Home/ But I am 99% sure it is actually Benedict https://www.postgresql.org/message-id/20000509083006Z72802-9734%2B1003%40pri... Who was doing tons of work on Koha at that time https://lists.gnu.org/archive/html/koha-cvs/2004-04/msg00060.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, thanks for the clarifications Chris 😊, I've really enjoyed doing this patch, learning a little bit more about kohas' history and all the great people who have been part of it. I'll give this patch another update with this new info and taking Katrins suggestions into account too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88479|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88869&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88480|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88870&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88481|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88871&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88482|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88872&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88873&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hows this Katrin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88869|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88898&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88870|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88899&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88871|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88900&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88872|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88901&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88873|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88902&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That last update removes all the 'Contributions Unknown' lines I'd inadvertently added as notes for myself to revisit later. One day I'd love to dig further into the history to understand what these people have done but I think that can be for another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The QA script has some complaints: FAIL docs/contributors.yaml OK git manipulation FAIL yaml_valid YAML Error: Invalid element in map FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL filters missing_filter at line 828 ( [% FOREACH r IN p.roles %]<li>[% INCLUDE role role=r %] ([% r.value.join(', ') %])</li>[% END %]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks good in the GUI! Looking at the YAML file I notice a big discrepancy in numbers to what we have on our git repository: http://git.koha-community.org/stats/koha-master/authors.html I think we don't use the numbers yet, so no blocker. But can you tell why? Some entries don't have a commits counter, like Marco Gaiarin: {} I believe the double names don't have the right capitalization in some cases: Pierre-marc => Pierre-Marc Jose-mario => Jose-Mario Pierre-luc => Pierre-Luc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88898|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89180&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88899|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89181&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88900|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89182&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88901|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89183&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88902|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89184&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed.. after our chat on IRC I'm not entirely sure why the commit numbers don't add up.. I'll investigate that in a followup bug as suggested.. as you say, they're not displayed yet anyway. Capitalisation fixes done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Yeah the number of commits in the yaml file is not correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could not compile /usr/share/koha/about.pl: Can't locate YAML/XS.pm in @INC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89180|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89199&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89181|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89200&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89182|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89201&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89183|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89202&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89184|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89203&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89204&action=edit Bug 21662: (follow-up) Drop YAML::XS, use YAML I mistakenly left us using YAML::XS when we don't already depend upon it. YAML is a sufficent alternative that we do already require. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89205&action=edit Bug 21662: (follow-up) Embelish contributor details Add details to the 'non-commiters' in the contributors list. Information gratefully recieved from Chris Cormack Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89199|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89208&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89200|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89209&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89201|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89210&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89202|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89211&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89203|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89212&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89204|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89213&action=edit Bug 21662: (follow-up) Drop YAML::XS, use YAML I mistakenly left us using YAML::XS when we don't already depend upon it. YAML is a sufficent alternative that we do already require. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89205|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89214&action=edit Bug 21662: (follow-up) Embelish contributor details Add details to the 'non-commiters' in the contributors list. Information gratefully recieved from Chris Cormack Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89215&action=edit Bug 21662: (follow-up) Corrections to YAMP for incompatible format YAML::XS and YAML output incompatible (but both valid) YAML files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89208|0 |1 is obsolete| | --- Comment #77 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89284&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89209|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89285&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89284|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89286&action=edit Bug 21662: Make history.txt whitespace consistent Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89285|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89287&action=edit Bug 21662: Update history.txt Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89210|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89288&action=edit Bug 21662: Add Contributors.yaml file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89211|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89289&action=edit Bug 21662: Use contributors.yaml for contributors list Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89212|0 |1 is obsolete| | --- Comment #83 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89290&action=edit Bug 21662: Other history correction Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89213|0 |1 is obsolete| | --- Comment #84 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89291&action=edit Bug 21662: (follow-up) Drop YAML::XS, use YAML I mistakenly left us using YAML::XS when we don't already depend upon it. YAML is a sufficent alternative that we do already require. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89214|0 |1 is obsolete| | --- Comment #85 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89292&action=edit Bug 21662: (follow-up) Embelish contributor details Add details to the 'non-commiters' in the contributors list. Information gratefully recieved from Chris Cormack Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89215|0 |1 is obsolete| | --- Comment #86 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89293&action=edit Bug 21662: (follow-up) Corrections to YAMP for incompatible format YAML::XS and YAML output incompatible (but both valid) YAML files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #87 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89294&action=edit Bug 21662: (QA follow-up) Minor corrections [1] Move doXulting and Universidad ORT Uruguay to Institutions. We do not mention the institution for each developer. [2] Removing Anonymous. [3] Adding the Bugzilla alias shantanoo as additional transliterated text. [4] Resolve typo Continious. [5] Removing three plural unused roles in about.tt. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #88 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Good job, Martin. Still some small things to correct in the names probably, but can be done later. And the sort order? TODO Examples: Koha Instance Knakk-koha, Koha Translators, Polytechnic University Koha Installation, Koha SAB CINECA For another report: Merging the several thanks sections? Also I think the attribution for Owen is rather small sized with the note 3.0+ Interface Design, while others have a large list of version numbers. Any idea to bring that a bit more in balance ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89302&action=edit Bug 21662: (QA follow-up) Be consistent between history and contributors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89302|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89303&action=edit Bug 21662: (QA follow-up) Be consistent between history and contributors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #88)
QA Comment: Good job, Martin. Still some small things to correct in the names probably, but can be done later. And the sort order?
Oh, I thought the sort order for contributors was good here.. I think we can handle the lists of roles in the followup bug that refactors the teams sections a bit too.
TODO Examples: Koha Instance Knakk-koha, Koha Translators, Polytechnic University Koha Installation, Koha SAB CINECA
For another report: Merging the several thanks sections?
Yes, I'd love to see that at some point
Also I think the attribution for Owen is rather small sized with the note 3.0+ Interface Design, while others have a large list of version numbers. Any idea to bring that a bit more in balance ?
So, the reason Owen isn't mentioned all that well here was that I kept the 'note' he had rather than backdating team roles for him (we all know he's basically be the go to guy for UX advice for years, but the 'Topic Expert - UX' role didn't exist for most of that. Perhaps we should do it retrospectively in another bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #92 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #91)
So, the reason Owen isn't mentioned all that well here was that I kept the 'note' he had rather than backdating team roles for him (we all know he's basically be the go to guy for UX advice for years, but the 'Topic Expert - UX' role didn't exist for most of that. Perhaps we should do it retrospectively in another bug?
Yes please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #93 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Martin, the number of commits is wrong because of this line: 39 $commitref->{ $bits[0] } = { name => $name, email => $email }; bits[0] is the timestamp of the commit. You are assuming it is unique, but it is not. So some commits are lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89610&action=edit fix bug in get_developers.pl I also removed all the other parts of the script, I am not able to run it, yaml file is missing from release-tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89610|application/x-perl |text/plain mime type| | Attachment #89610|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89610|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22893 [Bug 22893] contributors.yaml not correctly copied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've pushed a copy of a marginally cleaned up get_developers.pl script to the release-tools repo (with your fixes inlined). There's lots of commented out print statements that were used for debugging whilst the script was created. What I'd like to do next is distil down the logic and merge it into the koha-release script allowing for maintenance of both history and contributors files to be automated at release time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21626 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 [Bug 21626] Add 'current maintenance team' to the 'Koha team' page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89898&action=edit Bug 21662: (QA follow-up) Use commitdates over RM dates The manual maintanence of the history.txt file lead to some discrepancies in first commit dates for many contributors. After a discussion regarding the automation proccess (and with some of the contributors who would be most heavily affected) we decided to update the history file on mass to match the commite dates found in the repository. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89898|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89908&action=edit Bug 21662: (QA follow-up) Use commitdates over RM dates The manual maintanence of the history.txt file lead to some discrepancies in first commit dates for many contributors. After a discussion regarding the automation proccess (and with some of the contributors who would be most heavily affected) we decided to update the history file on mass to match the commite dates found in the repository. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This turned into somewhat of an architectural enhancement so I am not going to backport it at this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Final patch still needs pushing I'm afraid nick.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |We found that a few released in| |developers had been missed | |and a few others had been | |duplicated on the history | |page. This patchset | |corrects those mistakes and | |simplifies the process of | |updating our history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|We found that a few |We found that a few released in|developers had been missed |developers had been missed |and a few others had been |and a few others had been |duplicated on the history |duplicated on the history |page. This patchset |page. This patchset |corrects those mistakes and |corrects those mistakes and |simplifies the process of |simplifies the process of |updating our history. |maintaining our history | |record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #98)
Created attachment 89908 [details] [review] Bug 21662: (QA follow-up) Use commitdates over RM dates
The manual maintanence of the history.txt file lead to some discrepancies in first commit dates for many contributors. After a discussion regarding the automation proccess (and with some of the contributors who would be most heavily affected) we decided to update the history file on mass to match the commite dates found in the repository.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Final patch pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 [Bug 26425] Fix history.txt once and for all -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org