[Bug 18260] New: Koha::Biblio - Remove GetBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Bug ID: 18260 Summary: Koha::Biblio - Remove GetBiblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org C4::Biblio::GetBiblio can be replaced with Koha::Biblios->find -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 [Bug 18256] Koha::Biblio - Remove GetItemsCount -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61053&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Bug 18260 depends on bug 18256, which changed state. Bug 18256 Summary: Koha::Biblio - Remove GetItemsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleisha@catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Patch was unable to apply: Applying: Bug 18260: Koha::Biblio - Remove GetBiblio Using index info to reconstruct a base tree... M C4/Acquisition.pm M C4/Biblio.pm M C4/ILSDI/Services.pm M C4/ImportBatch.pm M C4/Serials.pm M Koha/REST/V1/Hold.pm M catalogue/imageviewer.pl M catalogue/itemsearch.pl M t/db_dependent/Acquisition.t M tools/batch_delete_records.pl Falling back to patching base and 3-way merge... Auto-merging tools/batch_delete_records.pl CONFLICT (content): Merge conflict in tools/batch_delete_records.pl Auto-merging t/db_dependent/Acquisition.t Auto-merging catalogue/itemsearch.pl Auto-merging catalogue/imageviewer.pl Auto-merging Koha/REST/V1/Hold.pm Auto-merging C4/Serials.pm Auto-merging C4/ImportBatch.pm Auto-merging C4/ILSDI/Services.pm Auto-merging C4/Biblio.pm Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 18260: Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61053|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63743&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63743|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 63760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63760&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/REST/V1/Hold.pm Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of GetBiblio was not tested too before. No blocker. catalogue/imageviewer.pl biblionumber is a CGI parameter here find should be tested Same for catalogue/issuehistory.pl opac/opac-imageviewer.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63760|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64823&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18277 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch rebased on top of bug 18277. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64825&action=edit Bug 18260: Handle nonexistent biblionumber in imageviewer.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5)
Koha/REST/V1/Hold.pm Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of GetBiblio was not tested too before. No blocker.
catalogue/imageviewer.pl biblionumber is a CGI parameter here find should be tested
That was already true before this patch, we must handle nonexistent biblionumber correctly on all catalogue scripts.
Same for catalogue/issuehistory.pl opac/opac-imageviewer.pl
I did not find a change in the behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64823|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64897&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64825|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64898&action=edit Bug 18260: Handle nonexistent biblionumber in imageviewer.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64899&action=edit Bug 18260: [QA Follow-up] Always something left? Remove second Koha::Biblios->find in imageviewer.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Bug 18260 depends on bug 18277, which changed state. Bug 18277 Summary: Koha::Biblio - Remove GetBiblionumberFromItemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19334 [Bug 19334] circulation history doesn't set biblionumber so left navigation is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 [Bug 19357] Error when submitting biblionumbers to batch record modification -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org