[Bug 32412] New: OPACShelfBrowser controls add extra Coce images to biblio-cover-slider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Bug ID: 32412 Summary: OPACShelfBrowser controls add extra Coce images to biblio-cover-slider Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Turn on Coce for the OPAC. 2. OPACShelfBrowser must be on 3. Find a record that returns a cover image and open it's detail page. 4. Use the next/previous navigation links in the OPACShelfBrowser 5. Notice how everytime you click on a control an extra cover image is added to the biblio-cover-slider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149143&action=edit Bug 32412: Empty coce container before appending image To test: 1. Apply patch and clear browser cache 2. Turn on Coce for the OPAC. 3. OPACShelfBrowser must be on 4. Find a record that returns a cover image and open it's detail page. 5. Use the next/previous navigation links in the OPACShelfBrowser 6. Notice that no extra image is being added to the biblio-cover-slider. 7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149143|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149219&action=edit Bug 32412: Empty coce container before appending image To test: 1. Apply patch and clear browser cache 2. Turn on Coce for the OPAC. 3. OPACShelfBrowser must be on 4. Find a record that returns a cover image and open it's detail page. 5. Use the next/previous navigation links in the OPACShelfBrowser 6. Notice that no extra image is being added to the biblio-cover-slider. 7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Works perfectly. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150567&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Lucas, your patch is working but I think it's actually hiding another bug: we should not reload the image for the bibliographic record when we are browsing the shelf. Do you agree with my follow-up patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Lucas, your patch is working but I think it's actually hiding another bug: we should not reload the image for the bibliographic record when we are browsing the shelf.
Do you agree with my follow-up patch?
yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150567|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150620&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149219|0 |1 is obsolete| | Attachment #150620|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150625&action=edit Bug 32412: Empty coce container before appending image To test: 1. Apply patch and clear browser cache 2. Turn on Coce for the OPAC. 3. OPACShelfBrowser must be on 4. Find a record that returns a cover image and open it's detail page. 5. Use the next/previous navigation links in the OPACShelfBrowser 6. Notice that no extra image is being added to the biblio-cover-slider. 7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150626&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I'm not seeing any images in the shelf browser after this patch. In the console I see "Uncaught TypeError: parent.find is not a function" from coce.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell@catalyst.net.n | |z Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Not backporting to 21.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Owen Leonard from comment #12)
I'm not seeing any images in the shelf browser after this patch. In the console I see "Uncaught TypeError: parent.find is not a function" from coce.js
Same here on 22.11. Can't say yet on 23.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Frédéric Demians from comment #15)
(In reply to Owen Leonard from comment #12)
I'm not seeing any images in the shelf browser after this patch. In the console I see "Uncaught TypeError: parent.find is not a function" from coce.js
Same here on 22.11. Can't say yet on 23.05.
Seen bug 33848? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #16)
Seen bug 33848?
No, but I should have, since it's the solution. Thanks. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org