[Bug 12300] New: Revert BZ10727 - Remove duplicate <br /> in printed hold notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Bug ID: 12300 Summary: Revert BZ10727 - Remove duplicate <br /> in printed hold notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org To be consistent with overdue notices, HOLD_PRINT model should be formated in html and <br /> written directly in the letter. In this case, replacing carriage return with <br /> duplicates new lines in the final printed file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10727 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12294 Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 28390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28390&action=edit Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28390|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28503&action=edit [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Exact reversion of 10727. Just thinking, again you will get all text in one line [1] [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727#c0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> ---
Exact reversion of 10727. Just thinking, again you will get all text in one line [1]
Sounds like we are reverting a partial solution to get back a partial problem :) BTW: Should gather_print_notices not look at the content of each message before deciding to do a replace? The message could be plain text or html depending on the letter definition. Can we use this opportunity to come up with a more elegant solution? Perhaps you could ask Jonathan to assist here since this comes close to his work on message transport types.. Moving status to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org