[Bug 28307] New: Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Bug ID: 28307 Summary: Make BakerTaylorEnabled preference separate for staff and OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The description of the BakerTaylorEnabled preference says it controls both OPAC and staff. In fact the feature isn't present in the staff interface. I propose to enable the feature in the staff interface and at the same time separate the preference into two: One for the OPAC and one for the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123198&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This only works for me if I turn on an additional image service, like Amazon. Both detail.tt and results.tt have a line like: [% IF ( AmazonCoverImages || LocalCoverImages || AdlibrisEnabled || (Koha.Preference('CustomCoverImages') && Koha.Preference('Cu stomCoverImagesURL')) ) %] I *think* BakerTaylorEnabled should be added there because B&T should be able to display without any of the other cover image services turned on? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125708&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 125743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125743&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125708|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 125744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125744&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make BakerTaylorEnabled |Enable BakerTaylorEnabled |preference separate for |content in the staff |staff and OPAC |interface Keywords| |release-notes-needed Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having a look here - I can' test BakerTaylor content, so having a real close look at the code. As Owen pointed out this was not present before, so I think the small thing here is that the pref description was wrong before, but the big thing is that we add the content to staff! So I took the liberty to adjust the pref description a bit (change back if you hate it) As we rename the pref for the OPAC, I expected a lot more name changes there. Checking with git grep I believe some were missed: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF ( BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[% BakerTaylorBookstoreURL |url %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |url %][% bt_id | uri %]" /></a>[% END %][% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: [% IF BakerTaylorEnabled %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && !Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF ( BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL | uri %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL | html %][% bt_id | html %]" /></a>[% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %] Only seeing this one was changed: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt: [% IF ( OPACBakerTaylorEnabled && bt_id ) %] I think the issue is in the test plan, it should be: Disable staff interface and only enable OPAC. Verify it all still shows correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enable BakerTaylorEnabled |Enable BakerTaylorEnabled |content in the staff |content in the staff |interface |interface with separate | |system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Having a look here - I can' test BakerTaylor content, so having a real close look at the code.
As Owen pointed out this was not present before, so I think the small thing here is that the pref description was wrong before, but the big thing is that we add the content to staff! So I took the liberty to adjust the pref description a bit (change back if you hate it)
As we rename the pref for the OPAC, I expected a lot more name changes there. Checking with git grep I believe some were missed:
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF ( BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[% BakerTaylorBookstoreURL |url %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |url %][% bt_id | uri %]" /></a>[% END %][% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: [% IF BakerTaylorEnabled %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && !Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF ( BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL | uri %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL | html %][% bt_id | html %]" /></a>[% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %]
Only seeing this one was changed:
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt: [% IF ( OPACBakerTaylorEnabled && bt_id ) %]
I think the issue is in the test plan, it should be: Disable staff interface and only enable OPAC. Verify it all still shows correctly.
Excuse my confusion here, I'd like to see this one move on. Do we need to edit code or only the test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We definitely need a follow-up patch (code change) for all the places the syspref rename has not taken into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To explain a bit more: we have a pref now that is "Opac...", but in the OPAC scripts the old name is still used almost everywhere. I believe the test plan should maybe be altered to in that you have to verify that the OPAC displays B&T content correctly, when BakerTaylorEnabled (staff side) is turned off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127222&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125743|0 |1 is obsolete| | Attachment #125744|0 |1 is obsolete| | Attachment #127222|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127223&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127224&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127225&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127223|0 |1 is obsolete| | Attachment #127224|0 |1 is obsolete| | Attachment #127225|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131784&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131785&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131786&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131784|0 |1 is obsolete| | Attachment #131785|0 |1 is obsolete| | Attachment #131786|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133274&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133275&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133276&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133274|0 |1 is obsolete| | Attachment #133275|0 |1 is obsolete| | Attachment #133276|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138137&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138138&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138139&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- When I try to access the opac-user page I am met with an error: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 1397: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127 It looks like there is a stray [% END %] in the template logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138137|0 |1 is obsolete| | Attachment #138138|0 |1 is obsolete| | Attachment #138139|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142193&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142194&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142195&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Juliet Heltibridle <jheltibridle@rcplib.org> --- (In reply to Owen Leonard from comment #27)
Created attachment 142195 [details] [review] Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
Check these pages in the OPAC:
- Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues
Works as expected on all the above pages except for search results -> RSS and recent comments ->RSS. This is my first time using a sandbox, so I'm not sure if I'm doing something wrong or not. It seems to me that the link for the RSS is not being directed back to the sandbox opac. Instead of https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search.pl?idx=kw&q=shakespeare&format=rss. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Juliet Heltibridle from comment #28)
(In reply to Owen Leonard from comment #27)
Created attachment 142195 [details] [review] [review] Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
Check these pages in the OPAC:
- Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues
Works as expected on all the above pages except for search results -> RSS and recent comments ->RSS. This is my first time using a sandbox, so I'm not sure if I'm doing something wrong or not. It seems to me that the link for the RSS is not being directed back to the sandbox opac. Instead of https://staff-coverimages.sandbox.bywatersolutions.com/cgi-bin/koha/members/ member.pl?quicksearch=1&circsearch=1&searchmember=shakespeare, it has http://coverimages.mydnsname.org:8080/cgi-bin/koha/opac-search. pl?idx=kw&q=shakespeare&format=rss.
Hi Juliet, the RSS will build the link from the OpacBaseURL system preference setting, if you correct that, it might work ok. Could you give it another go maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #30 from Juliet Heltibridle <jheltibridle@rcplib.org> --- Thank you Katrin. I updated the system preference. Cover images show correctly on the Comments RSS as well. But I get the following error when clicking on the RSS feed for a search results page: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Juliet Heltibridle from comment #30)
Thank you Katrin. I updated the system preference. Cover images show correctly on the Comments RSS as well. But I get the following error when clicking on the RSS feed for a search results page: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127
It might be unrelated to this patch set. It looks like a missing include (I recently had a similar error elsewhere) Owen, do you want to follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114 [Bug 32114] Template error in OPAC search results RSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Juliet Heltibridle from comment #30)
But I get the following error when clicking on the RSS feed for a search results page: Template process failed: file error - biblio_a_href: not found at /kohadevbox/koha/C4/Templates.pm line 127
This bug is in master too. I have submitted a fix on Bug 32114. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Juliet Heltibridle <jheltibridle@rcplib.org> --- (In reply to Owen Leonard from comment #27)
Created attachment 142195 [details] [review] Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
Check these pages in the OPAC:
- Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues
Cover images display in search results, bibligraphic details page, recent comments, recent comments RSS, and lists (both public & private), and summary checkouts and overdues. Cover images are still not displaying on the search results -> RSS feed. Additionally, cover images from Baker & Taylor do not display on the bibliographic details page on the staff intranet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #34 from Donna <bwsdonna@gmail.com> --- Just bumping this - it is still an issue in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 wfitzgibbon@faylib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wfitzgibbon@faylib.org --- Comment #35 from wfitzgibbon@faylib.org --- Fayetteville Public Library supports this bug. Would help our staff have consistency with what patrons and staff are seeing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142193|0 |1 is obsolete| | Attachment #142194|0 |1 is obsolete| | Attachment #142195|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169061&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169062&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169063&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the new system release notes| |preference | |`OPACBakerTaylorEnabled` in | |addition to the existing | |`BakerTaylorEnabled` system | |preference. While the first | |can be used to control | |Baker & Taylor content in | |the OPAC, the second will | |be used for the staff | |interface. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169061|0 |1 is obsolete| | Attachment #169062|0 |1 is obsolete| | Attachment #169063|0 |1 is obsolete| | --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175257&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175258&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175259&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175259|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175265&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175257|0 |1 is obsolete| | Attachment #175258|0 |1 is obsolete| | Attachment #175265|0 |1 is obsolete| | --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178730&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178731&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178732&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #46 from Juliet Heltibridle <jheltibridle@rcplib.org> --- (In reply to Owen Leonard from comment #45)
Created attachment 178732 [details] [review] Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
Check these pages in the OPAC:
- Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues
Everything looks okay in the OPAC, covers are showing Baker & Taylor. In the staff interface, it shows the Baker & Taylor cover in the search results, but it does not show it on the bibliographic details page unless you also have AmazonCoverImages set to show, and then only if there is an Amazon cover page for the item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178730|0 |1 is obsolete| | Attachment #178731|0 |1 is obsolete| | Attachment #178732|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180719&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180720&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180721&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I'm still not seeing the Baker & Taylor images on the staff side unless the Amazon setting is also turned on. And that's only in the item detail page. The same for the search page, except it doesn't show the B&T image, just the Amazon one, and an then you can click the green circles to try and see the B&T image, but there is none showing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180719|0 |1 is obsolete| | Attachment #180720|0 |1 is obsolete| | Attachment #180721|0 |1 is obsolete| | --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185395&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185396&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185397&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185398&action=edit Bug 28307: (follow-up) Correct ID of image container -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #55 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I tested the following scenarios: 1. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages OFF + OPACAmazonCoverImages OFF Result: Images from B&T show in OPAC and not in staff 2. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages ON + OPACAmazonCoverImages OFF Result: Images show from B&T and Amazon in OPAC, but not in staff 3. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages ON + OPACAmazonCoverImages ON Result: Both staff and OPAC show images from Amazon and B&T 4. BakerTaylorEnabled OFF + OPACBakerTaylorEnabled ON + AmazonCoverImages OFF + OPACAmazonCoverImages OFF Result: NO images show on OPAC or staff So it seems like OPACBakerTaylorEnabled isn't working in the OPAC if BakerTaylorEnabled is off, and BakerTaylorEnabled isn't working in the staff interface if any other enhanced cover image content is not turned on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #56 from Juliet Heltibridle <jheltibridle@rcplib.org> --- (In reply to Juliet Heltibridle from comment #55)
I tested the following scenarios: 1. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages OFF + OPACAmazonCoverImages OFF Result: Images from B&T show in OPAC and not in staff 2. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages ON + OPACAmazonCoverImages OFF Result: Images show from B&T and Amazon in OPAC, but not in staff 3. BakerTaylorEnabled ON + OPACBakerTaylorEnabled ON + AmazonCoverImages ON + OPACAmazonCoverImages ON Result: Both staff and OPAC show images from Amazon and B&T 4. BakerTaylorEnabled OFF + OPACBakerTaylorEnabled ON + AmazonCoverImages OFF + OPACAmazonCoverImages OFF Result: NO images show on OPAC or staff
So it seems like OPACBakerTaylorEnabled isn't working in the OPAC if BakerTaylorEnabled is off, and BakerTaylorEnabled isn't working in the staff interface if any other enhanced cover image content is not turned on.
I mistyped for #2: Result is Images show in OPAC from B&T, and images in staff show both Amazon & B&T -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #57 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- With B&T shutting down, I think this should be closed [1] [1] https://locusmag.com/2025/10/baker-taylor-prepares-to-shut-down/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org