https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36221 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38523 [Bug 38523] Simple quote in ILL standard form JS can break translations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi all. Is there any short-term plans to work on this? It affects es-ES users right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It sounds like moving them out of there... could fix the translation issue right away if they were part of the normal template structure. Is that a correct assumption? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, I filed bug 39031 a few days ago. I hit that road block when implementing an ILL backend with 'the new schema'. I feel like we could solve this by: * Accepting my patch. * Making Koha::ILL::Backend::Standard implement the right method. * Put the templates in the right place I also thought, while in this context, that we should implement methods for the OPAC and the Staff interface instead of a single one. And we could just remove the hardcoded `<interface-includes` dir and just use whatever the method returns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I'm on board with any of the proposed solutions. I just think that duplicating any file to both staff and OPAC templates is a bad practice we've been perpetuating for ever in Koha. Duplicating files for both staff+OPAC where the files are an exact match or a

95% overlap should be an option, sure, but not enforced. This is why I mentioned bug 35716 but, again, I understand that it may be out of scope here.

(In reply to Katrin Fischer from comment #8)

I think there might also be a use case for having them a bit different. For example the "extra fields" you can add in the form are not suitable for a end user right now and should not be shown in OPAC like they are now.

This is how FreeForm has always worked. I understand this is not a vallid excuse, but some functionality may actually make use of it e.g. openURL. Some third-parties that link back to Koha using openURL may return additional key:values that are not considered in the hardcoded form fields and this information may be needed for reporting or something similar. I'm not saying this is a huge blocker, I'm saying there's a use case where the additional fields may be needed even though the user may never have the need to use'em. Perhaps others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Pedro Amorim from comment #9)

I'm on board with any of the proposed solutions. I just think that duplicating any file to both staff and OPAC templates is a bad practice we've been perpetuating for ever in Koha. Duplicating files for both staff+OPAC where the files are an exact match or a >95% overlap should be an option, sure, but not enforced. This is why I mentioned bug 35716 but, again, I understand that it may be out of scope here.

I think we can focus on the problem to solve (i.e. templates not being translatable) and then have the discussion about 35716, as it has a broader impact on the project. But I fully understand where you are coming from. I'll try to improve 39031 and then use it on this bug for moving the templates.

(In reply to Katrin Fischer from comment #8)

...

I think there might also be a use case for having them a bit different. For example the "extra fields" you can add in the form are not suitable for a end user right now and should not be shown in OPAC like they are now.

This is how FreeForm has always worked. I understand this is not a vallid excuse, but some functionality may actually make use of it e.g. openURL. Some third-parties that link back to Koha using openURL may return additional key:values that are not considered in the hardcoded form fields and this information may be needed for reporting or something similar. I'm not saying this is a huge blocker, I'm saying there's a use case where the additional fields may be needed even though the user may never have the need to use'em. Perhaps others.

I agree this could be discussed on some other bug, as Katrin said. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 177749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177749&action=edit Bug 38340: Move templates Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177749|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 178057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178057&action=edit Bug 38340: Move templates Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178058|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178080&action=edit Bug 38340: Make Standard ILL backend templates translatable This patchset moves the `Standard` backend templates into the right places so they are picked up for translation. To test: 1. Apply this patches 2. Notice the `Standard` ILL backend works as expected 3. Run: $ ktd --shell k$ cd misc/translator/po k$ git fetch ; git reset --hard origin/main k$ cd .. k$ perl translate update es-ES k$ cd po k$ git diff 4. Inside the diff pager, make a search for 'backends/Standard' => SUCCESS: There are strings that come from the Standard backend! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Please run the QA script. Most of templates are no tidy here. They have been ignored during the big tidy because they were in an unusual directory and because they are very wrong. See "exclude" in get_js_files and get_tt_files from tidy.pl Note that this exclusion list is rewritten on bug 39115. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard ├── cancel.inc ├── confirm.inc ├── create.inc ├── edititem.inc ├── illview.inc ├── inc │   ├── custom_fields.inc │   ├── form_input_helpers.inc │   ├── forms │   │   ├── article.inc │   │   ├── book.inc │   │   ├── chapter.inc │   │   ├── conference.inc │   │   ├── dvd.inc │   │   ├── journal.inc │   │   ├── other.inc │   │   ├── resource.inc │   │   └── thesis.inc │   └── shared.js └── migrate.inc Do we have inc of inc? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 178415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178415&action=edit Bug 38340: Make Standard ILL backend templates translatable This patchset moves the `Standard` backend templates into the right places so they are picked up for translation. To test: 1. Apply this patches 2. Notice the `Standard` ILL backend works as expected 3. Run: $ ktd --shell k$ cd misc/translator/po k$ git fetch ; git reset --hard origin/main k$ cd .. k$ perl translate update es-ES k$ cd po k$ git diff 4. Inside the diff pager, make a search for 'backends/Standard' => SUCCESS: There are strings that come from the Standard backend! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, I tidied things. But I NEED HELP. I wasn't able to tidy create.inc: ``` perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc Tidying file 1/1 (koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc) [error] koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc: SyntaxError: Unexpected closing tag "option". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-e... (4:13) [error] 2 | #~64~# [error] 3 | #~65~# [error] > 4 | </option> [error] | ^^^^^^^^^ [error] 5 | at misc/devel/tidy.pl line 112. ``` and the error doesn't seem to make sense, or I'm just missing something. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #28 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I moved some code around, so this deserves a new testing round. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178414|0 |1 is obsolete| | --- Comment #29 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 178420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178420&action=edit Bug 38340: Move templates Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178418|0 |1 is obsolete| | --- Comment #31 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 178422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178422&action=edit Bug 38340: (follow-up) Refactor and tidy template files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---

From qa tools:

An error occurred : Cannot open /usr/share/koha/Koha/ILL/Backend/intra-includes/create.inc (No such file or directory) at /usr/share/koha/C4/TTParser.pm line 70. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #36 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180067&action=edit Bug 38340: Make Standard ILL backend templates translatable This patchset moves the `Standard` backend templates into the right places so they are picked up for translation. To test: 1. Apply this patches 2. Notice the `Standard` ILL backend works as expected 3. Run: $ ktd --shell k$ cd misc/translator/po k$ git fetch ; git reset --hard origin/main k$ cd .. k$ perl translate update es-ES k$ cd po k$ git diff 4. Inside the diff pager, make a search for 'backends/Standard' => SUCCESS: There are strings that come from the Standard backend! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #38 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #33)

From qa tools:

An error occurred : Cannot open /usr/share/koha/Koha/ILL/Backend/intra-includes/create.inc (No such file or directory) at /usr/share/koha/C4/TTParser.pm line 70.

Jonathan fixed this in QA tools. (In reply to Marcel de Rooy from comment #34)

FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc FAIL filters missing_filter at line 117 ( var core = [ [% whole.core %] ];)

FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/edititem.inc FAIL filters missing_filter at line 87 ( var core = [ [% whole.core %] ];)

FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/migrate.inc FAIL filters missing_filter at line 110 ( var core = [ [% whole.core %] ];)

FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc FAIL filters missing_filter at line 111 ( var core = [ [% whole.core %] ];)

Fixed in latest patch (squashed) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hmm.. I just applied these and I'm not sure your final squashed patch went in Tomas.. I'm still seeing those QA script errors I'm afraid -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #41 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #39)

Hmm.. I just applied these and I'm not sure your final squashed patch went in Tomas.. I'm still seeing those QA script errors I'm afraid

The missing filters are gone. What remains is the fact these inc files cannot stand on their own. Tell me how yours solve it or if I’m missing something. I mean, all looking at this code. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #43 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181216&action=edit Bug 38340: Make Standard ILL backend templates translatable This patchset moves the `Standard` backend templates into the right places so they are picked up for translation. To test: 1. Apply this patches 2. Notice the `Standard` ILL backend works as expected 3. Run: $ ktd --shell k$ cd misc/translator/po k$ git fetch ; git reset --hard origin/main k$ cd .. k$ perl translate update es-ES k$ cd po k$ git diff 4. Inside the diff pager, make a search for 'backends/Standard' => SUCCESS: There are strings that come from the Standard backend! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #45 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I re-did all the patchset because it wouldn't apply after the latest ILL changes. I tested it to work both in the staff interface and the OPAC. There are still this type of failures: ``` FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/thesis.inc FAIL valid_template ill_text_input_field: not found ``` Fixing them would require either: * Including `ill/backends/Standard/shared/form_input_helpers.inc` in each of them * Getting rid of the individual files per-type, and merging those forms into the main one (create.inc, both in OPAC and staff interface). The first one would mean including the helper .inc twice as it is already included (and used) and the `create.inc` level. The latter would imply a regression from Pedro's attempt to make things reusable (this patchset already had to split between OPAC and staff interface those files). My vote would be keeping it as-is. But I leave it to y'all to decide. I can do either. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #47 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #46)

I'd really really like to see this fixed, but I am not sure I understand the suggestion:

My vote would be keeping it as-is. But I leave it to y'all to decide. I can do either.

So that means ignoring the failures or am I misunderstanding? I think then we'd also need to take that into account for the QA script rewrite that aims to have all tests passing on all files.

I think we should push this ASAP and discuss somewhere else if the QA tools should be added an exception. I would just include all the files where needed, predating reusability. If this was a real blocker. We really need someone with a strong opinion against this patch set to express how they would do it. Otherwise taste predates a much needed feature and that’s bad for the project and the users -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181294&action=edit Bug 38340: Add exclusions to xt/author/valid-templates.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #51 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug 39600 does not apply, so I cannot follow-up myself here, but I would suggest to adjust the exclusions code Better to exclude to pass the directory ill/backends/Standard/shared/forms/ instead of all the files Then replace 134 if ( $_ =~ /${exclusion}$/ ) { with 134 if ( $_ =~ /$exclusion$/ || $_ =~ /^$exclusion/ ) { -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #53 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #52)

(In reply to Jonathan Druart from comment #51)

...

Bug 39600 does not apply, so I cannot follow-up myself here, but I would suggest to adjust the exclusions code Better to exclude to pass the directory ill/backends/Standard/shared/forms/ instead of all the files

Then replace 134 if ( $_ =~ /${exclusion}$/ ) { with 134 if ( $_ =~ /$exclusion$/ || $_ =~ /^$exclusion/ ) {

Sounds like a plan - does that work for you, Tomas? Should we file a omnibus/follow-up bug to fix those exclusions?

Sure, I didn't introduce such change only to avoid controversies :-P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #55 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181392&action=edit Bug 38340: Rewrite controllers This patch splits the controller in two: * A controller for staff users use * An unprivileged access controller The public one makes use of the state-of-the-art in Koha for public endpoints, using the `$c->auth->public` validation helper and leaving the (newly added) public path spec with no special permissions requirements. The staff-oriented endpoint gets the right permissions added (at least those used in the main `/ill/requests` endpoint. TODO: Tests need to be split for both controllers, and adjusted. TODO: The OPAC changes need to be redone using the public endpoint. TODO: The OPAC table should use kohaTable. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 [Bug 39739] OPAC's datatables.js out of sync with staff's -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39092 [Bug 39092] When loading an ILL backend plugin it should be cached -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #58 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #51)

Bug 39600 does not apply, so I cannot follow-up myself here, but I would suggest to adjust the exclusions code Better to exclude to pass the directory ill/backends/Standard/shared/forms/ instead of all the files

Then replace 134 if ( $_ =~ /${exclusion}$/ ) { with 134 if ( $_ =~ /$exclusion$/ || $_ =~ /^$exclusion/ ) {

That didn't work for me so I filed bug 39741 to discuss it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181215|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181541&action=edit Bug 38340: Move templates Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181217|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181543&action=edit Bug 38340: (follow-up) Refactor and tidy template files Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we have some failing tests, please check: xt/find-missing-op-in-forms.t .... 2/2 # Failed test 'The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478)' # at xt/find-missing-op-in-forms.t line 44. # got: '2' # expected: '0' # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc:21,170'; # $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/migrate.inc:18'; # Looks like you failed 1 test of 2. xt/find-missing-op-in-forms.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests xt/yaml_valid.t .................. ok xt/find-license-problems.t ....... ok xt/find-missing-csrf.t ........... 1/2 # Failed test 'The <form> in the following files are missing it's corresponding csrf_token include (see bug 22990)' # at xt/find-missing-csrf.t line 43. # got: '2' # expected: '0' # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/create.inc:170'; # $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/migrate.inc:18'; # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick follow-up and a nice win with this patch set to have caught the csrf issues. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39765 [Bug 39765] ILL - Backends are not working -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 [Bug 40315] xt/tt_tidy.t generates warnings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #69 from David Nind <david@davidnind.com> --- No changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 Bug 38340 depends on bug 39092, which changed state. Bug 39092 Summary: When loading an ILL backend plugin it should be cached https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39092 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.