[Bug 42353] New: Tell which version of node to use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Bug ID: 42353 Summary: Tell which version of node to use Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 38426 The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 [Bug 38426] Node.js v18 EOL around 25.05 release time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197256&action=edit Bug 42353: Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197257&action=edit Bug 42353: [22.11] Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/koha-com | |munity/koha-i18n/-/work_ite | |ms/2 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Related to https://gitlab.com/koha-community/koha-i18n/-/work_items/2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197263&action=edit Bug 42353: Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197267&action=edit Bug 42353: [22.11] Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 197386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197386&action=edit Bug 42353: [22.11] Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 197387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197387&action=edit Bug 42353: Store the node version in .nvmrc The context is koha-i18n and the Weblate sync. We need to know which version of node to use before running yarn install. Prior to the upgrade to Node 20 all our Koha versions were using the same version (18). Now 22.11 is using 18 and others are using 20. We need to announce which version is needed for each of our branch. Test plan: Apply this patch Install nvm: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash run `nvm use` => It tells you to install 20 nvm install 20 nvm use # will read .nvmrc and use 20 yarn install => Success Checkout Koha's branch 22.11.x (git checkout origin/22.11.x) Apply the patch for 22.11 nvm use => It tells you to install 18 nvm install 18 nvm use # wil read .nvmrc and use 18 yarn install => Success git checkout bug_42353 (main + 42353's patch for main) nvm use && yarn install => Success Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Note for anyone having tested this: don't forget to delete your node_modules directory. Otherwise over weeks/month on KTD it will get out of sync with /kohadevbox/node_modules/ And the inconsistent mix of node libs will cause some weird bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |lts_candidate, | |rel_25_05_candidate, | |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|lts_candidate |additional_work_needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197507&action=edit Bug 42353: (follow-up) Add .nvmrc to Makefile Patch from commit bd71ca3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #10)
Created attachment 197507 [details] [review] Bug 42353: (follow-up) Add .nvmrc to Makefile
Ha! I always forgot that... Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |lts_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org