[Bug 7554] New: Newlines break search paging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Bug #: 7554 Summary: Newlines break search paging Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: OPAC AssignedTo: jcamins@cpbibliography.com ReportedBy: jcamins@cpbibliography.com QAContact: koha.sekjal@gmail.com If you have newlines in the title of an item in your search results, the javascript search pagination on the OPAC details page is broken. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-17 16:24:09 UTC --- Further investigation reveals that newlines in titles generally break search results in the OPAC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-17 18:15:09 UTC --- Created attachment 7742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7742 Example record You will need to add an item to this example record so that it shows up on Master (due to bug 6488). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-17 18:18:20 UTC --- Created attachment 7743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7743 Bug 7554: Clean newlines in browse script Records with a newline in the title will break the Javascript search pagination on the OPAC without this patch. To test: 1. Import a record with a newline in the title (an example is attached to this bug) 2. Do a search that turns up the record and at least one other 3. View the detail page for one of the other records 4. Observe that there is a javascript error 5. Apply patch 6. Repeat search 7. Observe that there is no javascript error -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7743|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-19 06:59:28 UTC --- Created attachment 7752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7752 Bug 7554: Clean newlines in browse script Records with a newline in the title will break the Javascript search pagination on the OPAC without this patch. To test: 1. Import a record with a newline in the title (an example is attached to this bug) 2. Do a search that turns up the record and at least one other 3. View the detail page for one of the other records 4. Observe that there is a javascript error 5. Apply patch 6. Repeat search 7. Observe that there is no javascript error Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Simple template change, works well -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7752|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-20 13:35:04 UTC --- Created attachment 7774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7774 Signed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-20 13:35:51 UTC --- QA: Works. Small change. Marked as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7554 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org