[Bug 34979] New: AutoApprovePatronProfileSettings missing from sysprefs.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Bug ID: 34979 Summary: AutoApprovePatronProfileSettings missing from sysprefs.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I'm wondering if this is normal. The system preference AutoApprovePatronProfileSettings is in updatedatabase.pl and in patrons.pref, but not in sysprefs.sql (unless I'm not looking in the right place). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Also missing - EmailSMSSendDriverFromAddress - HidePersonalPatronDetailOnCirculation - ManaToken - OPACDetailQRCode - OverDriveAuthname - OverDriveWebsiteID - RecordStaffUserOnCheckout - SelfCheckInModuleUserID And not removed from the db after being moved out of sysprefs, also not sure if it's supposed to be like that or not. - OpacMoreSearches - OPACMySummaryNote This one is in sysprefs.sql but not in updatedatabase.pl - UpdateNotForLoanStatusOnCheckout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AutoApprovePatronProfileSet |System preferences missing |tings missing from |from sysprefs.sql |sysprefs.sql | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Feel free to close if this is completely irrelevant :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20057 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20356 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21121 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17047 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21082 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15492 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24220 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For OpacMoreSearches and OPACMySummaryNote, I see they are removed in dbrevs, but I ran updatedatabase.pl on an old db and they are still there. This might be a 'me' problem, (i.e. I might not be doing something correctly) I don't know... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For OpacMoreSearches and OPACMySummaryNote, I see they are removed in dbrevs, but I ran updatedatabase.pl on an old db and they are still there. This might be a 'me' problem, (i.e. I might not be doing something correctly) I don't know... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We should definitely add these to sysprefs.sql. I feel like we used to have an automated test or something in the QA script to catch these, but couldn't find it. Joubu, do you know maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #5)
We should definitely add these to sysprefs.sql.
Agreed.
I feel like we used to have an automated test or something in the QA script to catch these, but couldn't find it. Joubu, do you know maybe?
t/db_dependent/check_sysprefs.t It is only making sure sysprefs in sysprefs.sql are in the DB. Now that we are testing the upgrade DB process (from 19.11) we could have the other way around and catch those missing ones (ie. make sure that the sysprefs in the DB are also in sysprefs.sql) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160614&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160615&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160616&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The mistake in OAI-PMH:AutoUpdateSetsEmbedItemData (Set vs. Sets) made the system preference non-functional, so updating this to a bug. Be gentle in review, tried my best with the unit test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160614|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 160617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160617&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160615|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 160618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160618&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160616|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 160619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160619&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would suggest to only display the "Added" message if the syspref has been added. Can be achieved with: $dbh->do(q{INSERT IGNORE statement}) == 1 && say "Added system preference 'foo'"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160617|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160978&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160618|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160979&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160619|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160980&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160981&action=edit Bug 34979: (follow-up) Only print message when preference was added Implements Joubu's suggestion from comment#14 Test plan remains unchanged. You can run the database update a second time to see the difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tried to further improve the database update for the "UPDATE" statements, but I didn't manage to only create the output when something actually was changed. It's always returning 1, I guess because the database isn't case-sensive and the WHERE statement will always return something to update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160978|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160997&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160979|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160998&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160980|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160999&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160981|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 161000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161000&action=edit Bug 34979: (follow-up) Only print message when preference was added Implements Joubu's suggestion from comment#14 and improves on it for the cases where we fix capitalization. Test plan remains unchanged. You can run the database update a second time to see the difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Figured something out :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160997|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161227&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160998|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161228&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160999|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161229&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161000|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 161230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161230&action=edit Bug 34979: (follow-up) Only print message when preference was added Implements Joubu's suggestion from comment#14 and improves on it for the cases where we fix capitalization. Test plan remains unchanged. You can run the database update a second time to see the difference. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is another signoff :) (checked also last commit function) Also tested with an upgrade from 19.11.x: this fix still catches all (test doesn't complain) I couldn't spin a KTD older than 19.11, for some reason MySQL takes all RAM at startup and I have to kill it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #29)
I couldn't spin a KTD older than 19.11, for some reason MySQL takes all RAM at startup and I have to kill it.
oh, mysql doesn't work but mariadb does! Then it fail when trying to update package cpanoutdated Err:1 http://httpredir.debian.org/debian stretch/main amd64 cpanoutdated all 0.31-1 404 Not Found ok, at least that makes more sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161227|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161418&action=edit Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql The unit tests will help to detect any discrepancies and missing entries in the YAML and sysprefs.sql files. To test: * Apply only this patch * prove -v t/db_dependent/check_sysprefs.t * It will fail. * Apply other patches * Run database update * Re-run test. It should pass now. * Recreate your database or reset_all with patches applied. * System preferences should be installed correctly. * Test should still pass. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161228|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161419&action=edit Bug 34979: Sort sysprefs.sql alphabetically This doesn't add or remove any entries, but only changes the sequence of entries to be alphabetic again, compared to: SELECT variable FROM systempreferences ORDER BY variable; Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161229|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161420&action=edit Bug 34979: Fix mistakes in system preference files highlighted by unit test This fixes the mistakes the unit test helped to find: * Add missing system preferences to sysprefs.sql * Correct spelling for AutoUpdateSetsEmbedItemData * Correct capitalization, so that code and pref files match * Fix OverDrive sytem preferences, where explanation/options columns where switched, resulting in strange database entries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161230|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161421&action=edit Bug 34979: (follow-up) Only print message when preference was added Implements Joubu's suggestion from comment#14 and improves on it for the cases where we fix capitalization. Test plan remains unchanged. You can run the database update a second time to see the difference. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #38 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhby87@gmail.com --- Comment #39 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Error from this upgrade Upgrade to 23.11.02.002 [19:05:56]: Bug 34979 - Fix system preference discrepancies Fix mistakes in system preferences, if necessary: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'OAI-PMH:AutoUpdateSetsEmbedItemData' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36232 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36232 [Bug 36232] Updating database structure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se --- Comment #40 from Hans Pålsson <hans.palsson@hkr.se> --- Dito, upgrade from 23.11.02 fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hans Pålsson from comment #40)
Dito, upgrade from 23.11.02 fails.
I am sorry for that. If you remove the pref from the database and then re-run the script, that should fix things. We are also working on a fix here: bug 36232 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- In the test suite, during the update DB process: Use of uninitialized value $pref in string eq at /kohadevbox/koha/installer/data/mysql/db_revs/231200005.pl line 89. I think we need that: - if ( $pref eq "OAI-PMH:AutoUpdateSetEmbedItemData" ) { + if ( $pref && $pref eq "OAI-PMH:AutoUpdateSetEmbedItemData" ) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #42)
In the test suite, during the update DB process:
Use of uninitialized value $pref in string eq at /kohadevbox/koha/installer/data/mysql/db_revs/231200005.pl line 89.
I think we need that: - if ( $pref eq "OAI-PMH:AutoUpdateSetEmbedItemData" ) { + if ( $pref && $pref eq "OAI-PMH:AutoUpdateSetEmbedItemData" ) {
Is this on the right bug report? Looks like it should be on a new report as this has been closed out for a long time. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org