[Bug 38256] New: Link vendors to ERM data providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Bug ID: 38256 Summary: Link vendors to ERM data providers Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org There should be the ability to link an ERM data provider to a vendor record. This will enable us to get cost data from baskets/orders and link to usage statistics -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175150&action=edit Bug 38256: Add a column for a vendor (cherry picked from commit 757664a10e2bea8632c9c44bfe3e9d7f589903fc) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175151&action=edit Bug 38256: Update API specs for new column (cherry picked from commit ca1a85aa8819f9dd24e1bacc285913919f8950d6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175152&action=edit Bug 38256: DBIC files (cherry picked from commit c3ce31be20b5e593b4793eb500ae1183d9773e8b) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175153&action=edit Bug 38256: Update the UI to handle the new vendor field (cherry picked from commit c4f308ed64ffc0420b1ced1426925ac84cac54ce) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #5 from Mathieu Saby <mathsabypro@gmail.com> --- Matt could you add a test plan please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175150|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182592&action=edit Bug 38256: Add a column for a vendor (cherry picked from commit 757664a10e2bea8632c9c44bfe3e9d7f589903fc) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175151|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182593&action=edit Bug 38256: Update API specs for new column (cherry picked from commit ca1a85aa8819f9dd24e1bacc285913919f8950d6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175152|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182594&action=edit Bug 38256: DBIC files (cherry picked from commit c3ce31be20b5e593b4793eb500ae1183d9773e8b) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175153|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182595&action=edit Bug 38256: Update the UI to handle the new vendor field (cherry picked from commit c4f308ed64ffc0420b1ced1426925ac84cac54ce) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182592|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 183022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183022&action=edit Bug 38256: Add a column for a vendor (cherry picked from commit 757664a10e2bea8632c9c44bfe3e9d7f589903fc) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182593|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 183023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183023&action=edit Bug 38256: Update API specs for new column (cherry picked from commit ca1a85aa8819f9dd24e1bacc285913919f8950d6) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182594|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 183024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183024&action=edit Bug 38256: DBIC files (cherry picked from commit c3ce31be20b5e593b4793eb500ae1183d9773e8b) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182595|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 183025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183025&action=edit Bug 38256: Update the UI to handle the new vendor field (cherry picked from commit c4f308ed64ffc0420b1ced1426925ac84cac54ce) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds a release notes| |'Vendor' field to the ERM | |eUsage data providers' | |form, with a dropdown list | |of vendors created in the | |acquisitions module. | | | |This | |ability to link an ERM data | |provider to a vendor record | |will allow reporting on | |cost data from baskets and | |orders, and linking to | |usage statistics. --- Comment #14 from David Nind <david@davidnind.com> --- I have signed off. However, I did note that for a new vendor to show up in the dropdown list on the usage data provider, that I have to do a hard refresh of the page. Testing notes (using KTD): 1. Apply the patch 2. Update the database: updatedatabase 3. Rebuild the schema: dbic (not sure if this is required or not) 4. Rebuild the Vue application: yarn build 5. Restart everything: restart_all 6. Clear your browser cache. 7. Enable the ERM module. 8. Add a new data provider: eUsage > Data providers > New usage data provider 9. Note that there is a new 'Vendor' field under the description field, and the dropdown lists current vendors created in the acquisitions module. 10. Add and edit a usage data provider, and link them to a vendor (My Vendor). 11. Add a new vendor in the acquisitions module, repeat step 10 and link the usage provider to the new vendor. (A hard browser refresh may be required.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183025|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189183&action=edit Bug 38256: Update the UI to handle the new vendor field (cherry picked from commit c4f308ed64ffc0420b1ced1426925ac84cac54ce) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA checks Result: [FAIL] Koha/ERM/EUsage/UsageDataProvider.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/ERM/EUsage/UsageDataProvider.pm` [FAIL] installer/data/mysql/atomicupdate/bug_38256-link_vendors_to_data_providers.pl FAIL file_permissions -> Fixed in follow-up patch 2) Code review Bonus points for having everything translatable :) 3) Testing Vendor can be added or left off. Seems all good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183022|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193537&action=edit Bug 38256: Add a column for a vendor (cherry picked from commit 757664a10e2bea8632c9c44bfe3e9d7f589903fc) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183023|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193538&action=edit Bug 38256: Update API specs for new column (cherry picked from commit ca1a85aa8819f9dd24e1bacc285913919f8950d6) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183024|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193539&action=edit Bug 38256: DBIC files (cherry picked from commit c3ce31be20b5e593b4793eb500ae1183d9773e8b) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189183|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193540&action=edit Bug 38256: Update the UI to handle the new vendor field (cherry picked from commit c4f308ed64ffc0420b1ced1426925ac84cac54ce) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193541&action=edit Bug 38256: Fix file permissions and tidy Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In the DBupdate: ADD CONSTRAINT `erm_usage_data_providers_ibfk_1` FOREIGN KEY (`vendor_id`) REFERENCES `aqbooksellers` (`id`) ON DELETE CASCADE ON UPDATE CASCADE IN kohastructure.sql: CONSTRAINT `erm_usage_data_provider_ibfk_1` FOREIGN KEY (`vendor_id`) REFERENCES `aqbooksellers` (`id`) ON DELETE SET NULL ON UPDATE CASCADE They do not match. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! Sorry for missing it in QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #24 from Michaela Sieber <michaela.sieber@kit.edu> --- Interesting :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 202235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202235&action=edit Bug 38256: (QA follow-up) Correct atomic update Patch from commit 65a07e3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was about to test the follow-up and give this another nudge, but started wondering: Are we creating the link in the right direction? With this patch you can link an identity provider to a vendor record. You could also link multiple data providers to one vendor. But: Would it maybe be more likely the other way around as one data provider might be a platform serving for multiple publishers/vendors? So would we rather like to link multiple vendors to the same data provider? Another use case that comes to mind is when different branches have their own vendor record, but the electronic resources are purchased collectively (hope that makes sense) Then the column should be created on the aqbooksellers table. (Failed QA for raising attention, please feel free to set back to PQA) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org