[Bug 14142] New: Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Bug ID: 14142 Summary: Holds queue viewer only displays first subtitle from marc keyword mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38825&action=edit Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38825|0 |1 is obsolete| | --- Comment #2 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 39809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39809&action=edit Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melissa@bywatersolutions.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 --- Comment #3 from Heather Braum <hbraum@nekls.org> --- I've tested this patch and it works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39809|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39845&action=edit Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear Signed-off-by:Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- Hi, This patch doesn't apply for 3.18. If you feel that it should be included, please resolve any issues and resubmit a patch for inclusion in 3.18.x. Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org