[Bug 25301] New: Category code is blank when renewing or editing expired/expiring patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Bug ID: 25301 Summary: Category code is blank when renewing or editing expired/expiring patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When renewing or editing the details of an expired patron via the "Renew" or "Edit details" links, there is a blank argument to "categorycode=". At a glance, it doesn't seem to cause problems, so we should either fix the argument, or remove the parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- I can change template to prevent empty 'categorycode=' from being added: [% IF categorycode %]&categorycode=[% categorycode | html %][% END %] After checking repository history and template stash I wasn't able to find any traces of 'categorycode' template parameter defined at all, in both /members/moremember.pl and /circ/circulations.pl, if that so, then we should remove `&categorycode=[% categorycode | html %]` from templates. If you can double check me and confirm that 'categorycode' not populated as template parameter in these perl files, then I propose for it's removal. I can commit the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22134 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I confirm, that does not make sense. Coming from commit e193254e357e52f87e10f9b03e350781d2613062 Bug 22134: Add account expiration information to patron details Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 [Bug 22134] Add account expiration information to patron details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 104418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104418&action=edit Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Also I inspected "circulation.tt" template as well, as it has the same problem that "moremember.tt" had, link "Edit details" attempts to send parameter "categorycode" that is empty as it is not defined in "circulation.pl" same way it was not defined in "moremember.pl" I could not find any traces of how it appeared there before. Do you think it will be reasonable to remove it from "circulation.tt" as well as a separate patch or a new ticket? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Separate patch please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #6 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 104484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104484&action=edit Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104418|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104630&action=edit Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104484|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104631&action=edit Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104630|0 |1 is obsolete| | Attachment #104631|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104656&action=edit Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104657&action=edit Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104658&action=edit Bug 25301: removed URI parameter "categorycode" from the toolbar Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27350 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27350 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27350 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27350 [Bug 27350] Reinstate patron categorycode in URL when editing a patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org