[Bug 31238] New: Unable to save authorised value to frameworks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Bug ID: 31238 Summary: Unable to save authorised value to frameworks subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org While working on bug 31154 I stumbled on problem described above. As it states I'm unable to save authorised value to frameworks subfields and was wondering is anyone able to repeat this. I suspect that this is caused by changes made in bug 29001, before it variable $authorised_value in marc_subfields_structure.pl is succesfully filled with value indented to be saved. After applying bug again $authorised_value is undef. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There seems to be a minor typo on marc_subfields_structure.pl,
$input->param("authorised_values_$id") should be
$input->param("authorised_value_$id")
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 138119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138119&action=edit Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138119|0 |1 is obsolete| | --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 138125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138125&action=edit Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138125|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138231&action=edit Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Severity|enhancement |major Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, QA script happy, code looks good, passing QA :) Severity upped to major. Feel free to change if that's too much. Surely that's at least normal severity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas, can you please check if this is needed in 22.05 (see comment on bug 29001? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I don't reproduce the issue on 21.11.x branch. Also bz29001 was not applied there so maybe that one is not needed for backport. Won't backport unless asked to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 [Bug 29001] Subfields attributes are not preserved when order is changed in framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31869 [Bug 31869] Unable to save thesaurus value to frameworks subfields -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org