[Bug 6726] New: when sms on the messaging table is misaligned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Bug #: 6726 Summary: when sms on the messaging table is misaligned Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org See attached. When you have SMS on there is an extra column wihthout checkboxes in the messaging table. To test enter any character in the SMSDriver preference and that column will appear. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-08-15 22:41:05 UTC --- Created attachment 5024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5024 extra column -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|when sms on the messaging |When SMS is enabled the |table is misaligned |messaging table is | |misaligned -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-08-16 12:51:24 UTC --- Created attachment 5029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5029 Proposed fix The SMS section of the template was commented out in the patch pushed for Bug 5889, 'Allow message names to be translatable' with the comment 'fixing columns overflow.' That seems to have been a cosmetic fix for what I can only imagine was a different bug? Also fixing a T:T variable scope error. After applying this patch the "SMS" column in the Patron messaging preferences should appear when the SMSSendDriver preference is not empty. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5029|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-08-16 20:57:53 UTC --- Created attachment 5039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5039 [SIGNED-OFF] Fix for Bug 6726 - When SMS is enabled the messaging table is misaligned The SMS section of the template was commented out in the patch pushed for Bug 5889, 'Allow message names to be translatable' with the comment 'fixing columns overflow.' That seems to have been a cosmetic fix for what I can only imagine was a different bug? Also fixing a T:T variable scope error. After applying this patch the "SMS" column in the Patron messaging preferences should appear when the SMSSendDriver preference is not empty. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-08-16 20:58:51 UTC --- a follow up is needed because I forgot to report that this is happening in the OPAC as well, but I've signed off on the staff client fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |--- --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-23 03:15:58 UTC --- Pushed the patch, resetting patch status as a follow up is needed for the staff client -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-08-24 16:09:39 UTC --- Created attachment 5118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5118 [SIGNED-OFF] Follow-up fix for Bug 6726 - When SMS is enabled the messaging table is misaligned Corresponding fix for the OPAC Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Signed Off --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-08-24 16:10:08 UTC --- follow up signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-25 17:24:02 UTC --- Simple template-only fixes, easy to read, marking both as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-26 03:06:07 UTC --- Pushed the follow up, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 --- Comment #10 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:38 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com --- Comment #11 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-11-15 16:06:48 UTC --- Is the table still ok with SMS disabled ? (when I try, only my Item Checkout and Item Check-in lines look good) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org