https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21221 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Will need bug 21221 to apply. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21221 [Bug 21221] Implement blocking errors for members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77801&action=edit Bug 21222: (bug 20226 follow-up) Fix patron creation Since bug 20226 you cannot longer creation a patron, memberentry.pl will explode with Template process failed: undef error - DBIC result _type isn't of the _type Category at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc line 22. The problem is that "patron" is actually defined and the test in str/members-menu.inc does not work as expected. It comes from commit 7b1d08df0f4f69c52826c80a13158245287f4c00 Bug 19936: Replace Generate_Userid - Update the occurrences where I needed $patron to be defined in order to use Koha::Patron->generate_userid on an blessed object. But this was actually wrong, as it could have side-effects. Test plan: Create a new patron Edit it Retest bug 19936 and make sure the userid is generated correctly in the different situations -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77801|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77811&action=edit Bug 21222: (bug 20226 follow-up) Fix patron creation Since bug 20226 you cannot longer creation a patron, memberentry.pl will explode with Template process failed: undef error - DBIC result _type isn't of the _type Category at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc line 22. The problem is that "patron" is actually defined and the test in str/members-menu.inc does not work as expected. It comes from commit 7b1d08df0f4f69c52826c80a13158245287f4c00 Bug 19936: Replace Generate_Userid - Update the occurrences where I needed $patron to be defined in order to use Koha::Patron->generate_userid on an blessed object. But this was actually wrong, as it could have side-effects. Test plan: Create a new patron Edit it Retest bug 19936 and make sure the userid is generated correctly in the different situations Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77811|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77890&action=edit Bug 21222: (bug 20226 follow-up) Fix patron creation Since bug 20226 you cannot longer creation a patron, memberentry.pl will explode with Template process failed: undef error - DBIC result _type isn't of the _type Category at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc line 22. The problem is that "patron" is actually defined and the test in str/members-menu.inc does not work as expected. It comes from commit 7b1d08df0f4f69c52826c80a13158245287f4c00 Bug 19936: Replace Generate_Userid - Update the occurrences where I needed $patron to be defined in order to use Koha::Patron->generate_userid on an blessed object. But this was actually wrong, as it could have side-effects. Test plan: Create a new patron Edit it Retest bug 19936 and make sure the userid is generated correctly in the different situations Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not required in 18.05.x as we don't have bug 20226. -- You are receiving this mail because: You are watching all bug changes.