[Bug 38080] New: Sorting options for holdings table are incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Bug ID: 38080 Summary: Sorting options for holdings table are incorrect Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The sorting seems to rely on the correct ordering of the columns from the DB/YAML - the current order does not match the displayed order, so if you select to sort by CCODE, we actually sort by callnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 [Bug 38079] Add ability to choose sorting for holdings table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't recreate, can you provide more details please? http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Click "Collection" => http://localhost:8081/api/v1/biblios/4/items?&_page=1&_per_page=20&_match=contains&_order_by=%2Bme.collection_code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Bug 38080 depends on bug 38079, which changed state. Bug 38079 Summary: Add ability to choose sorting for holdings table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Bug 38080 depends on bug 38079, which changed state. Bug 38079 Summary: Add ability to choose sorting for holdings table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30633 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |michaela.sieber@kit.edu Component|Staff interface |OPAC --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- I do recreate the problem at the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38079 |14919 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Caused by commit 4fa34acc414a1580019df62c28bb39bb6d9f3e85 Bug 14919: Add holds history for patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 [Bug 14919] Holds history for patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38079 [Bug 38079] Add ability to choose sorting for holdings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188142&action=edit Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- This bug has certainly been opened for the staff. In the OPAC the problem shouldn't be visible before bug 30633. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188142|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 188451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188451&action=edit Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the default sort release notes| |order for the OPAC holdings | |table, so that the selected | |table setting sorting | |default value is used. | |Previously, it was not | |correctly using this | |setting (for example, | |setting the shelving | |location as the default | |sort order did not work). --- Comment #7 from David Nind <david@davidnind.com> --- I hope I have tested this correctly. Testing notes (using KTD on main, bug 30633 is already included in main) 1. Replicate the issue: 1.1 Find a record with multiple items. I used record 255 - Perl template toolkit, with four items. 1.2 Change the shelving locations for each item, so that each item is different. I edited items so that the shelving locations were General stacks, New materials shelf, Fiction, Children's area. 1.3 For the OPAC holdings table setting (Administration > Other > Table settings > OPAC > biblio-detail > holdingst), set the default sort order to shelving location (item_shelving_location). 1.4 Set OpacLocationOnDetail = on a separate column. 1.5 Open the record details page in the OPAC. 1.6. Note the collection code column is used to sort the holdings table (the Collection column has the ascending arrow in dark green highlighted). 1.7 Note that the shelving location was not used as the default sorting order. 2. Apply the patch. 3. Reset everything (reset_all). 4. Repeat steps 1.1 to 1.5. 5. Note that now the shelving location is used to sort the items (the shelving location column has the ascending arrow in dark green highlighted), and these are in ascending alphabetical order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188451|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188661&action=edit Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the default sort |This fixes the default sort release notes|order for the OPAC holdings |order for the OPAC holdings |table, so that the selected |table, so that the default |table setting sorting |table sorting setting is |default value is used. |used. Previously, it was |Previously, it was not |not correctly using this |correctly using this |setting (for example, |setting (for example, |setting the shelving |setting the shelving |location as the default |location as the default |sort order did not work). |sort order did not work). | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- I think that this has caused the checkout table to overflow out of the checkouts tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #12)
I think that this has caused the checkout table to overflow out of the checkouts tab.
Then again... that's the wrong table... so must be be something else but it's a weird coincidence... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #13)
(In reply to David Cook from comment #12)
I think that this has caused the checkout table to overflow out of the checkouts tab.
Then again... that's the wrong table... so must be be something else but it's a weird coincidence...
Ok maybe it's already been overflowing for a long time and my prod instances just hide columns to make it fit... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38080 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org