[Bug 5013] New: "New patron" menu button broken on circulation patron select screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 Summary: "New patron" menu button broken on circulation patron select screen Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 If type a patron name into the "check out" form and come to the page where you can choose from a list of existing patrons, there is a "New" menu button which is supposed to offer a drop-down list of patron categories. This button is broken, displaying no menu at all. The markup for the button comes from patron-toolbar.inc which is also used on members-home.pl. The button on members-home.pl works fine. In the template is a loop for displaying the categories: <!--TMPL_LOOP Name="categoryloop"--> { text: "<!--TMPL_VAR Name="description"-->", url: "/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=<!--TMPL_VAR Name="categorycode"-->" }, <!--/TMPL_LOOP--> members-home.pl contains code to build this loop variable: my @categories=C4::Category->all; $template->param( branchloop=>(defined $branch?GetBranchesLoop($branch):GetBranchesLoop()), categoryloop=>\@categories, ); There is no mention of "categoryloop" in circulation.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2368 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2382 Additional change Menu was working on members-home.pl but not on members.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed follow-up patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2501 pro -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2501|0 |1 is patch| | Attachment #2501|application/octet-stream |text/plain mime type| | Attachment #2501|pro |Proposed patch description| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 2501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2501 Proposed patch The pull down for category in patron's advanced search was only showing any and no patron categories. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-08-31 16:35:16 UTC --- *** Bug 5188 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> 2010-08-31 17:03:42 UTC ---
*** Bug 5188 has been marked as a duplicate of this bug. ***
I agree that your patch should solved bug 5188. I'd have find it if it had been attached to a separate bug... Thanks Katrin. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution| |FIXED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-10-06 22:23:46 UTC --- Tested successfully on current head, closing bug. Plz reopen if you still see problems. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org